feat(router): Add new NavigationCancellation code and events for igno…#48024
Closed
atscott wants to merge 1 commit intoangular:mainfrom
Closed
feat(router): Add new NavigationCancellation code and events for igno…#48024atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
atscott
force-pushed
the
navigationcancelignorefeat
branch
from
e7305b6 to
6ca166b
Compare
pullapprove
bot
requested review from
alxhub,
jessicajaniuk and
pkozlowski-opensource
pkozlowski-opensource
added
the
action: cleanup
atscott
force-pushed
the
navigationcancelignorefeat
branch
2 times, most recently
from
bc33beb to
293b229
Compare
atscott
removed
the
action: cleanup
atscott
force-pushed
the
navigationcancelignorefeat
branch
from
293b229 to
9307918
Compare
jessicajaniuk
approved these changes
Nov 17, 2022
Contributor
jessicajaniuk
left a comment
jessicajaniuk
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
AndrewKushnir
approved these changes
Nov 17, 2022
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
Reviewed-for: public-api, fw-router
pullapprove
bot
requested review from
MarkTechson,
jelbourn,
josephperrott and
pkozlowski-opensource
angular-robot
bot
added
detected: deprecation
atscott
force-pushed
the
navigationcancelignorefeat
branch
from
3d4c40f to
8f398ee
Compare
angular-robot
bot
removed
detected: deprecation
atscott
force-pushed
the
navigationcancelignorefeat
branch
from
8f398ee to
420318c
Compare
atscott
removed request for
MarkTechson,
alxhub,
dylhunn,
jelbourn,
josephperrott and
pkozlowski-opensource
atscott
added
action: global presubmit
atscott
force-pushed
the
navigationcancelignorefeat
branch
from
420318c to
fbcfe7e
Compare
The Router currently silently ignores navigations for two reasons: 1. By default, same URL navigations are ignored. When this situation is encountered, the navigation is ignored without any events 2. A `UrlHandlingStrategy` may ignore some URLs. For situations when the strategy returns `false` for `shouldProcessUrl`, the Router silently ignores the URL and updates its internal state without running matching, guards, or resolver logic. This commit adds new `NavigationSkipped` events for the above two situations.
atscott
force-pushed
the
navigationcancelignorefeat
branch
from
fbcfe7e to
ea52596
Compare
Contributor
Author
atscott
added
action: merge
Contributor
|
This PR was merged into the repository by commit 73f03ad. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…angular#48024) The Router currently silently ignores navigations for two reasons: 1. By default, same URL navigations are ignored. When this situation is encountered, the navigation is ignored without any events 2. A `UrlHandlingStrategy` may ignore some URLs. For situations when the strategy returns `false` for `shouldProcessUrl`, the Router silently ignores the URL and updates its internal state without running matching, guards, or resolver logic. This commit adds new `NavigationSkipped` events for the above two situations. PR Close angular#48024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…red navigations
The Router currently silently ignores navigations for two reasons:
UrlHandlingStrategymay ignore some URLs. For situations when the strategy returnsfalseforshouldProcessUrl, the Router silently ignores the URL and updates its internal state without running matching, guards, or resolver logic.This commit adds new
NavigationCancellationcodes andNavigationCancelevents for the above two situations.