feat(core): Add TestBed.runInContext to help test functions which use inject#47955
Closed
atscott wants to merge 1 commit into
Closed
feat(core): Add TestBed.runInContext to help test functions which use inject#47955atscott wants to merge 1 commit into
TestBed.runInContext to help test functions which use inject#47955atscott wants to merge 1 commit into
Conversation
pullapprove
Bot
requested review from
AndrewKushnir,
alxhub and
pkozlowski-opensource
atscott
force-pushed
the
TestBedRunInContext
branch
2 times, most recently
from
cd3cc27 to
a13ec33
Compare
AndrewKushnir
approved these changes
Nov 4, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
atscott
added
merge: caretaker note
atscott
force-pushed
the
TestBedRunInContext
branch
from
5760999 to
49324e4
Compare
…s which use `inject` This commit adds `TestBed.runInInjectionContext` which is equivalent to `TestBed.inject(EnvironmentInjector).runInContext`. This function will help make tests for functions which call `inject` from `@angular/core` a little bit less verbose.
atscott
force-pushed
the
TestBedRunInContext
branch
from
49324e4 to
3f45e2d
Compare
AndrewKushnir
approved these changes
Nov 17, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
dylhunn
approved these changes
Nov 21, 2022
dylhunn
left a comment
dylhunn
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api
Contributor
|
@atscott Looks like this has a presubmit issue |
dylhunn
added
action: cleanup
atscott
removed
the
action: cleanup
Contributor
Author
|
Caretaker Note: Please ignore the |
atscott
added
merge: caretaker note
Contributor
|
This PR was merged into the repository by commit 6acae14. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trekladyone
pushed a commit
to trekladyone/angular
that referenced
this pull request
Feb 1, 2023
…s which use `inject` (angular#47955) This commit adds `TestBed.runInInjectionContext` which is equivalent to `TestBed.inject(EnvironmentInjector).runInContext`. This function will help make tests for functions which call `inject` from `@angular/core` a little bit less verbose. PR Close angular#47955
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds
TestBed.runInContextwhich is equivalent toTestBed.inject(EnvironmentInjector).runInContext. This function will help make tests for functions which callinjectfrom@angular/corea little bit less verbose.