refactor(docs-infra): update safevalues and account for API changes - #47048
Closed
devversion wants to merge 2 commits into
Closed
devversion wants to merge 2 commits into
devversion wants to merge 2 commits into
Conversation
bjarkler
self-requested a review
August 5, 2022 13:17
bjarkler
approved these changes
Aug 5, 2022
Updates `safevalues` to unblock angular#46707. As part of this commit the necessary refactorings due to API changes are also made.
Looks like the `ngsw-config.json` file needs to be updated after a new redirect being added in: angular#46820.
devversion
force-pushed
the
update-safevalues
branch
from
August 5, 2022 14:05
36d6161 to
4cdc83b
Compare
devversion
marked this pull request as ready for review
August 5, 2022 14:13
devversion
added
comp: docs-infra
target: patch
|
You can preview 4cdc83b at https://pr47048-4cdc83b.ngbuilds.io/. |
jessicajaniuk
approved these changes
Aug 5, 2022
Contributor
|
This PR was merged into the repository by commit 0b392af. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
safevaluesto unblock #46707. As part of this committhe necessary refactorings due to API changes are also made.