Conversation
The implementation of the `DefaultTitleStrategy` was modeled after the existing strategy patterns in the Router. These patterns were developed before the `providedIn` syntax for injectables. We can simplify the model a lot by providing the default in the factory of the abstract class. Note that the other strategy patterns aren't touched in this PR due to how long they've existed. Because they have been there for such a long time, it's possible there will need to be some adjustments to code if/when they are refactored to do the same.
atscott
added
area: router
target: patch
AndrewKushnir
approved these changes
Jul 18, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Nice refactoring 馃憤
AndrewKushnir
approved these changes
Jul 18, 2022
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: public-api
jessicajaniuk
approved these changes
Jul 18, 2022
jessicajaniuk
left a comment
jessicajaniuk
left a comment
Contributor
There was a problem hiding this comment.
reviewed-for: public-api, fw-testing
Contributor
|
This PR was merged into the repository by commit bde925b. |
jessicajaniuk
pushed a commit
that referenced
this pull request
Jul 18, 2022
The implementation of the `DefaultTitleStrategy` was modeled after the existing strategy patterns in the Router. These patterns were developed before the `providedIn` syntax for injectables. We can simplify the model a lot by providing the default in the factory of the abstract class. Note that the other strategy patterns aren't touched in this PR due to how long they've existed. Because they have been there for such a long time, it's possible there will need to be some adjustments to code if/when they are refactored to do the same. PR Close #46876
jessicajaniuk
pushed a commit
that referenced
this pull request
Jul 18, 2022
The implementation of the `DefaultTitleStrategy` was modeled after the existing strategy patterns in the Router. These patterns were developed before the `providedIn` syntax for injectables. We can simplify the model a lot by providing the default in the factory of the abstract class. Note that the other strategy patterns aren't touched in this PR due to how long they've existed. Because they have been there for such a long time, it's possible there will need to be some adjustments to code if/when they are refactored to do the same. PR Close #46876
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the
DefaultTitleStrategywas modeled after theexisting strategy patterns in the Router. These patterns were developed
before the
providedInsyntax for injectables. We can simplify themodel a lot by providing the default in the factory of the abstract
class.
Note that the other strategy patterns aren't touched in this PR due to
how long they've existed. Because they have been there for such a long
time, it's possible there will need to be some adjustments to code
if/when they are refactored to do the same.