Skip to content

Conversation

@why520crazy
Copy link
Contributor

@why520crazy why520crazy commented Mar 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from mgechev March 15, 2022 02:08
@why520crazy why520crazy changed the title docs: add ngx-gantt "EXPLORE ANGULAR RESOURCES" page docs: add ngx-gantt to "EXPLORE ANGULAR RESOURCES" page Mar 15, 2022
@why520crazy why520crazy force-pushed the add-resource-ngx-gantt branch from e9c2b72 to 6b3c479 Compare March 15, 2022 02:24
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker comp: docs target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Mar 15, 2022
@ngbot ngbot bot modified the milestone: Backlog Mar 15, 2022
@ngbot
Copy link

ngbot bot commented Mar 15, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/angular: size" is failing
    failure status "ci/circleci: aio_preview" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@ngbot ngbot bot added this to the Backlog milestone Mar 15, 2022
@gkalpak
Copy link
Member

gkalpak commented Mar 15, 2022

merge-assistance: The aio_preview and size CI failures are unrelated to this PR.

@atscott
Copy link
Contributor

atscott commented Mar 15, 2022

This PR was merged into the repository by commit e47ba49.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants