refactor(zone.js): remove onProp eventNames array to reduce the bundle size #45230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
added
the
target: patch
JiaLiPassion
force-pushed
the
zone-events-patch
branch
3 times, most recently
from
165cafb to
7d62a12
Compare
Contributor
|
FYI, adding "PullApprove: disable" since it's a patch-only version of already approved PR (#40962). |
JiaLiPassion
force-pushed
the
zone-events-patch
branch
from
7d62a12 to
e64c7db
Compare
jessicajaniuk
added
the
action: cleanup
This was referenced Mar 9, 2022
Contributor
|
@JiaLiPassion Can you retarget this for the |
JiaLiPassion
force-pushed
the
zone-events-patch
branch
2 times, most recently
from
bc8c43e to
9dc1e81
Compare
…e size Zone.js supports the google closure compiler in the advance optimization mode, to prevent closure compiler modify the `onProperty` name such as `Element.prototype.onclick`, Zone.js implements the `onProperty` patch logic by declaring all the event names in the source code, this increases the bundle size and also require updating the event names array to keep the information updated. Now google closure compiler has the required event names defined in the built-in externs files, so zone.js can use more simple implementation and decrease the bundle size of zone.js (about 4k).
JiaLiPassion
force-pushed
the
zone-events-patch
branch
from
9dc1e81 to
d443cd3
Compare
Contributor
Author
|
@atscott , sure, I just rebased this PR to 13.3.x |
atscott
removed
the
action: cleanup
Contributor
|
@JiaLiPassion Is this ready to be merged? |
JiaLiPassion
added
the
action: cleanup
Contributor
Author
|
@dylhunn , the |
Contributor
|
No worries, thanks! |
jessicajaniuk
removed request for
AndrewKushnir,
alxhub,
atscott and
jessicajaniuk
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR with #40962 for the
13.2.xpatch branch.Zone.js supports the google closure compiler in the advance optimization mode,
to prevent closure compiler modify the
onPropertyname such asElement.prototype.onclick,Zone.js implements the
onPropertypatch logic by declaring all theevent names in the source code, this increases the bundle size and also require
updating the event names array to keep the information updated.
Now google closure compiler has the required event names defined in the built-in
externs files, so zone.js can use more simple implementation and decrease the bundle size
of zone.js (about 4k).