fix(forms): improve error message for invalid value accessors #45192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameryousuf
force-pushed
the
improve_value_accessor_error_message
branch
from
7e15ca1 to
c104e66
Compare
dylhunn
suggested changes
Feb 25, 2022
AndrewKushnir
added
action: review
improve error message for invalid value accessors when accessor is not provided as array
ameryousuf
force-pushed
the
improve_value_accessor_error_message
branch
from
65ed10d to
158a7d4
Compare
AndrewKushnir
added
action: presubmit
AndrewKushnir
approved these changes
Mar 15, 2022
Contributor
AndrewKushnir
left a comment
AndrewKushnir
left a comment
There was a problem hiding this comment.
@ameryousuf thanks for applying additional changes 👍
The changes look good, I'll run tests in Google's codebase and let you know if there are any specific use-cases that we should address in this PR.
Thank you.
Contributor
|
Presubmit (internal-only link). |
AndrewKushnir
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
AndrewKushnir
added
the
merge: caretaker note
Contributor
|
Merge-assistance: the change was reviewed and approved, but Dylan is OOO, so I can't get this PR to the "green" state. The PR is ready for merge. |
Contributor
|
This PR was merged into the repository by commit 9db9091. |
atscott
pushed a commit
that referenced
this pull request
Mar 15, 2022
improve error message for invalid value accessors when accessor is not provided as array PR Close #45192
atscott
pushed a commit
that referenced
this pull request
Mar 15, 2022
improve error message for invalid value accessors when accessor is not provided as array PR Close #45192
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 23, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/animations](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fanimations/13.2.6/13.3.0) | | [@angular/common](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcommon/13.2.6/13.3.0) | | [@angular/compiler](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/13.2.6/13.3.0) | | [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/13.2.6/13.3.0) | | [@angular/core](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fcore/13.2.6/13.3.0) | | [@angular/forms](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fforms/13.2.6/13.3.0) | | [@angular/platform-browser](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/13.2.6/13.3.0) | | [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/13.2.6/13.3.0) | | [@angular/router](https://github.com/angular/angular) | dependencies | minor | [`13.2.6` -> `13.3.0`](https://renovatebot.com/diffs/npm/@angular%2frouter/13.2.6/13.3.0) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v13.3.0`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1330-rc0-2022-03-16) [Compare Source](angular/angular@13.2.7...13.3.0) ##### core | Commit | Type | Description | | -- | -- | -- | | [b5bb614c74](angular/angular@61a316c) | feat | support TypeScript 4.6 ([#​45190](angular/angular#45190)) | #### Special Thanks Alistair Kane, Andrew Scott and Kristiyan Kostadinov <!-- CHANGELOG SPLIT MARKER --> ### [`v13.2.7`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#​1327-2022-03-16) [Compare Source](angular/angular@13.2.6...13.2.7) ##### forms | Commit | Type | Description | | -- | -- | -- | | [eac94f0945](angular/angular@eac94f0) | fix | improve error message for invalid value accessors ([#​45192](angular/angular#45192)) | #### Special Thanks Alistair Kane, Amer Yousuf, Andrew Scott, Jessica Janiuk, Lee Cooper, alirezaghey and why520crazy <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1227 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #44486
What is the new behavior?
Does this PR introduce a breaking change?
Other information