fix(compiler-cli): Support resolve animation name from the DTS #45107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanwonder
force-pushed
the
resolve-animation-name-from-dts
branch
2 times, most recently
from
cce1dd7 to
9513a15
Compare
jessicajaniuk
added
the
area: compiler
JoostK
reviewed
Feb 16, 2022
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Outdated
Show resolved
Hide resolved
ivanwonder
force-pushed
the
resolve-animation-name-from-dts
branch
from
9513a15 to
5f91105
Compare
Contributor
Author
|
@atscott This is the fix for animation completion in the DTS |
Contributor
|
I'll leave this one for @JoostK to review since he knows how this part works much better than I do :) |
JoostK
reviewed
Feb 18, 2022
packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts
Outdated
Show resolved
Hide resolved
packages/compiler-cli/src/ngtsc/annotations/component/test/component_spec.ts
Outdated
Show resolved
Hide resolved
Before this, the compiler resolves the value in the DTS as dynamic. If the `trigger` is imported from `@angular/animations`, this PR will use FFR to simulate the actual implementation in JS and extracts the animation name.
ivanwonder
force-pushed
the
resolve-animation-name-from-dts
branch
from
5f91105 to
a1ff918
Compare
JoostK
approved these changes
Feb 19, 2022
Member
JoostK
left a comment
JoostK
left a comment
There was a problem hiding this comment.
Thanks for identifying this problem and providing a fix!
JoostK
added
action: merge
This comment was marked as resolved.
This comment was marked as resolved.
atscott
added
target: minor
Contributor
|
@ivanwonder This had a merge conflict with the patch branch. Could you create a new PR that targets the |
Contributor
|
This PR was merged into the repository by commit c0778b4. |
14 tasks
Contributor
Author
|
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
…ar#45107) Before this, the compiler resolves the value in the DTS as dynamic. If the `trigger` is imported from `@angular/animations`, this PR will use FFR to simulate the actual implementation in JS and extracts the animation name. PR Close angular#45107
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, the compiler resolves the value in the DTS as dynamic.
If the
triggeris imported from@angular/animations, this PR willuse FFR to simulate the actual implementation in JS and extracts the
animation name.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information