Skip to content

docs: Match description with element in lifecycle hooks example #45063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kane-alistair wants to merge 1 commit into from
Closed

docs: Match description with element in lifecycle hooks example #45063

kane-alistair wants to merge 1 commit into from

Conversation

@kane-alistair
Copy link
Contributor

@kane-alistair kane-alistair commented Feb 12, 2022 •
edited
Loading

Changes <div> to <p> in description to match the elements in the screenshot.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Documentation reads <div> where the code examples uses <p>

Issue Number: N/A

What is the new behavior?

Documentation reads <p> to match the code examples

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from alxhub February 12, 2022 19:56
@ngbot ngbot bot added this to the Backlog milestone Feb 14, 2022
@jessicajaniuk
Copy link
Contributor

jessicajaniuk commented Feb 14, 2022

@alistairkane92 Looks like the commit message needs to be fixed, and we need your CLA signed. Otherwise this looks ready to go.

@jessicajaniuk jessicajaniuk added the target: patch This PR is targeted for the next patch release label Feb 14, 2022
@kane-alistair
Copy link
Contributor Author

kane-alistair commented Feb 14, 2022

jessicajaniuk I've signed the CLA and amended the commit message. Thanks!

@AndrewKushnir AndrewKushnir added the action: merge The PR is ready for merge by the caretaker label Mar 8, 2022
@kane-alistair @AndrewKushnir
docs: update <div> to <p> in lifecycle-hooks.md
94bf3fa 
Changes <div> to <p> in description to match the elements in the screenshot.

Update lifecycle-hooks.md

Changes <div> to <p> in description to match the elements in the screenshot.
@ngbot
Copy link

ngbot bot commented Mar 8, 2022

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "ci/circleci: components-repo-unit-tests" is failing
    pending status "pullapprove" is pending
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

AndrewKushnir
AndrewKushnir approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alistairkane92 thanks for improving Angular docs!

@AndrewKushnir AndrewKushnir removed the request for review from alxhub March 9, 2022 17:07
@atscott
Copy link
Contributor

atscott commented Mar 9, 2022

This PR was merged into the repository by commit 2e2c80a.

@atscott atscott closed this in 2e2c80a Mar 9, 2022
atscott pushed a commit that referenced this pull request Mar 9, 2022
@kane-alistair @atscott
docs: update <div> to <p> in lifecycle-hooks.md (#45063)
10de528 
Changes <div> to <p> in description to match the elements in the screenshot.

Update lifecycle-hooks.md

Changes <div> to <p> in description to match the elements in the screenshot.

PR Close #45063
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Apr 9, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@AndrewKushnir AndrewKushnir AndrewKushnir approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

5 participants

@kane-alistair @jessicajaniuk @atscott @AndrewKushnir @alxhub