Conversation
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments
There was a problem hiding this comment.
Thanks @import-brain for helping to make our docs better
I'm approving this but in general it would be great if PRs contains more significant improvements. Mostly, these additional commas are subjective and stylistic and one could argue they are not really needed.
One further thing to note for future changes. To strictly follow out guidelines, the commit message header should be in present tense rather than past. E.g. docs: fix minor grammar mistakes in CONTRIBUTING.
Reviewed-for: global-docs-approvers
petebacondarwin
added
action: review
@petebacondarwin Ah I see, thanks for the help! I'll try to make more significant improvements next time, and thanks for informing me about the present tense rule, I didn't realize that! :) |
ejcheng
changed the title
devversion
added
action: merge
jessicajaniuk
removed
the
action: presubmit
|
This PR was merged into the repository by commit b1c0286. |
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments PR Close #43684
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments PR Close #43684
changed second big block of comments to use multi-line comment structure instead of multiple single-line comments PR Close #43684
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
…r#43684) changed second big block of comments to use multi-line comment structure instead of multiple single-line comments PR Close angular#43684
4 participants
Fixed second big blob of comments in packages/core/index.ts to use multiline comments
Fixed grammar mistakes in documentation throughout project
PR Checklist
Please check if your PR fulfills the following requirements:
(Second and third checkboxes do not apply to this PR)
PR Type
What kind of change does this PR introduce?