feat(core): support TypeScript 4.4#43281
Conversation
3dd89b2 to
7634b1e
Compare
|
Just a heads up from the ngcc perspective: it has some integration tests that use TypeScript to compile TS sources to JS as that was generally a good way to know that ngcc is capable of processing the output from TS, but now that we're transitioning to Ivy partial compilation and compiling libs with View Engine will not be supported in v13 there isn't necessarily a need for ngcc to process libraries that have been compiled using TS 4.4. We may want to revise the tests to stick to TS 4.3, or maybe there's an alternative approach (or maybe it doesn't break with this update). |
d5d706e to
d6609dd
Compare
|
FYI presubmits (including a global one) are successful, so I'm removing the "presubmit" label. |
alxhub
left a comment
There was a problem hiding this comment.
Reviewed-for: global-approvers
In angular#43281 I had to add a `resolutions`for `typescript` due to the `api-extractor` being locked down to an older version. Now that it has been updated, we don't need the workaround anymore.
|
So... Are TypeScript 4.2 and 4.3 going to be supported by Angular 13? |
|
They won't. There will be a follow-up PR to this to drop support once the other repos have upgraded. |
|
Thanks, @crisbeto! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds support for TypeScript 4.4. High-level overview of the changes made in this PR:
typescript@4.4.2andtslib@2.3.0.useUnknownInCatchVariablescompiler option has been disabled so that we don't have to cast error objects explicitly everywhere.__spreadArraycall inside child class constructors. I had to update a couple of places in the runtime and ngcc to be able to pick up the calls correctly.(0, foo)(arg1, arg2)for imported function calls. I had to update a few of our tests to account for it. See Indirect calls for imported functions microsoft/TypeScript#44624.ngtsctest setup calls the privatematchFilesfunction from TS. I had to update our usage, because a new parameter was added.hasTrailingCommaproperty. I updated the usage to pass in the value when constructing the object instead.