refactor(docs-infra): minor refactorings/style changes#42396
Closed
gkalpak wants to merge 5 commits into
Closed
Conversation
gkalpak
added
refactoring
|
You can preview cdb40a0 at https://pr42396-cdb40a0.ngbuilds.io/. |
gkalpak
added
the
action: review
petebacondarwin
approved these changes
May 28, 2021
gkalpak
added
action: cleanup
gkalpak
force-pushed
the
refactor-aio-dark-mode-cleanup
branch
from
cdb40a0 to
9b9a2f6
Compare
gkalpak
added
action: review
Member
Author
|
@petebacondarwin, I have added three new commits with some more refactorings/fixes/docs changes. PTAL 🙏 |
|
You can preview 9b9a2f6 at https://pr42396-9b9a2f6.ngbuilds.io/. |
petebacondarwin
approved these changes
May 29, 2021
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Nice - one typo in the content and one in a commit:
fix(docs-infra): improve homepage layout in print mode
In #41129, the `.hero-logo` image what changed from an `<img>` element
^^^^
petebacondarwin
added
the
action: cleanup
This commit includes some minor refactorings and style changes as a follow-up to PR angular#41129. (The changes were minor enough that didn't warrant blocking the PR.)
This commit removes the `_typography-theme.scss` file that is currently not used. The file contains a single Sass mixin (`docs-site-typography-theme()`), which is never called.
In angular#41129, the `.hero-logo` image was changed from an `<img>` element to a `<div>` with an image background. As a result, in print mode (where browsers often omit backgrounds to save ink) the logo was not present. This commit fixes this by ensuring the word `Angular` is displayed as a title instead of the logo in print mode. It also hides the `Get started` button in print mode, since it doesn't add any value. Before: ![homepage-print before][1] After: ![homepage-print after][2] [1]: https://user-images.githubusercontent.com/8604205/120068867-889e6080-c08b-11eb-9bd5-233d8592f7ec.png [2]: https://user-images.githubusercontent.com/8604205/120068869-89cf8d80-c08b-11eb-8740-a68a5ef68c34.png
… theming) in angular.io
gkalpak
force-pushed
the
refactor-aio-dark-mode-cleanup
branch
from
9b9a2f6 to
83a5874
Compare
gkalpak
removed
the
action: cleanup
|
You can preview 83a5874 at https://pr42396-83a5874.ngbuilds.io/. |
petebacondarwin
approved these changes
May 30, 2021
petebacondarwin
left a comment
petebacondarwin
left a comment
Contributor
There was a problem hiding this comment.
Reviewed-for: global-docs-approvers
gkalpak
added
action: merge
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 1, 2021
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 1, 2021
In #41129, the `.hero-logo` image was changed from an `<img>` element to a `<div>` with an image background. As a result, in print mode (where browsers often omit backgrounds to save ink) the logo was not present. This commit fixes this by ensuring the word `Angular` is displayed as a title instead of the logo in print mode. It also hides the `Get started` button in print mode, since it doesn't add any value. Before: ![homepage-print before][1] After: ![homepage-print after][2] [1]: https://user-images.githubusercontent.com/8604205/120068867-889e6080-c08b-11eb-9bd5-233d8592f7ec.png [2]: https://user-images.githubusercontent.com/8604205/120068869-89cf8d80-c08b-11eb-8740-a68a5ef68c34.png PR Close #42396
AndrewKushnir
pushed a commit
that referenced
this pull request
Jun 1, 2021
In #41129, the `.hero-logo` image was changed from an `<img>` element to a `<div>` with an image background. As a result, in print mode (where browsers often omit backgrounds to save ink) the logo was not present. This commit fixes this by ensuring the word `Angular` is displayed as a title instead of the logo in print mode. It also hides the `Get started` button in print mode, since it doesn't add any value. Before: ![homepage-print before][1] After: ![homepage-print after][2] [1]: https://user-images.githubusercontent.com/8604205/120068867-889e6080-c08b-11eb-9bd5-233d8592f7ec.png [2]: https://user-images.githubusercontent.com/8604205/120068869-89cf8d80-c08b-11eb-8740-a68a5ef68c34.png PR Close #42396
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some minor refactorings and style changes as a follow-up to PR #41129.
(The changes were minor enough that didn't warrant blocking the PR.)