Repository navigation
docs: convert the last my-app components to `app-root' - #42256
Closed
petebacondarwin wants to merge 1 commit into
Closed
petebacondarwin wants to merge 1 commit into
petebacondarwin wants to merge 1 commit into
Conversation
petebacondarwin
added
comp: docs
action: review
|
You can preview 9f45194 at https://pr42256-9f45194.ngbuilds.io/. |
gkalpak
approved these changes
May 24, 2021
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Reviewed-for: global-docs-approvers
Member
|
Minor commit message typo: -`app-root'
+`app-root` |
gkalpak
approved these changes
May 24, 2021
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Reviewed-for: global-docs-approvers
Most of these were fixed in other PRs but there were are couple of stragglers. Note that `my-app` components in non-documentation facing code, such as compliance tests have not been changed. Fixes angular#20235
petebacondarwin
force-pushed
the
docs-remove-my-app
branch
from
May 24, 2021 13:14
9f45194 to
51e6799
Compare
gkalpak
approved these changes
May 24, 2021
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Reviewed-for: global-docs-approvers
|
You can preview 51e6799 at https://pr42256-51e6799.ngbuilds.io/. |
petebacondarwin
added
action: presubmit
Contributor
Author
|
Googler: this is a docs-only commit so it should not need a presubmit. |
gkalpak
approved these changes
May 24, 2021
AndrewKushnir
approved these changes
May 24, 2021
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
LGTM, also forced g3 status to "green" since it's a docs-only change.
AndrewKushnir
removed
the
action: presubmit
petebacondarwin
added
the
action: merge
umairhm
pushed a commit
to umairhm/angular
that referenced
this pull request
May 28, 2021
Most of these were fixed in other PRs but there were are couple of stragglers. Note that `my-app` components in non-documentation facing code, such as compliance tests have not been changed. Fixes angular#20235 PR Close angular#42256
iRealNirmal
pushed a commit
to iRealNirmal/angular
that referenced
this pull request
Jun 4, 2021
Most of these were fixed in other PRs but there were are couple of stragglers. Note that `my-app` components in non-documentation facing code, such as compliance tests have not been changed. Fixes angular#20235 PR Close angular#42256
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of these were fixed in other PRs but there were are couple of stragglers.
Note that
my-appcomponents in non-documentation facing code, such ascompliance tests have not been changed.
Fixes #20235