Skip to content

Revert "fix(zone.js): should continue to executue listeners when throw error" #41707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AndrewKushnir wants to merge 2 commits into from
Closed

Revert "fix(zone.js): should continue to executue listeners when throw error" #41707

AndrewKushnir wants to merge 2 commits into from

Conversation

@AndrewKushnir
Copy link
Contributor

@AndrewKushnir AndrewKushnir commented Apr 19, 2021

This PR reverts a couple commits from #41562. The changes caused CI to become unstable (randomly failing).

// cc @JiaLiPassion

@AndrewKushnir
Revert "test(zone.js): should invoke XHR task even onload handler thr…
6443a02 
…ow error. (angular#41562)"

This reverts commit 6910118.

Reason: this change introduces race conditions on CI.
@AndrewKushnir AndrewKushnir added action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release PullApprove: disable labels Apr 19, 2021
@ngbot ngbot bot modified the milestone: Backlog Apr 19, 2021
@google-cla google-cla bot added the cla: yes label Apr 19, 2021
josephperrott
josephperrott approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewKushnir
Revert "fix(zone.js): should continue to executue listeners when thro…
719cac2 
…w error (angular#41562)"

This reverts commit 5c48cd3.

Reason: that change introduces race conditions on CI.
@AndrewKushnir AndrewKushnir force-pushed the zonejs_rollback_41562 branch from 7d2f82c to 719cac2 Compare April 19, 2021 19:31
AndrewKushnir added a commit that referenced this pull request Apr 19, 2021
@AndrewKushnir
Revert "fix(zone.js): should continue to executue listeners when thro…
d58747d 
…w error (#41562)" (#41707)

This reverts commit 5c48cd3.

Reason: that change introduces race conditions on CI.

PR Close #41707
AndrewKushnir added a commit that referenced this pull request Apr 19, 2021
@AndrewKushnir
Revert "test(zone.js): should invoke XHR task even onload handler thr…
ba5b9ca 
…ow error. (#41562)" (#41707)

This reverts commit 6910118.

Reason: this change introduces race conditions on CI.

PR Close #41707
AndrewKushnir added a commit that referenced this pull request Apr 19, 2021
@AndrewKushnir
Revert "fix(zone.js): should continue to executue listeners when thro…
92fb804 
…w error (#41562)" (#41707)

This reverts commit 5c48cd3.

Reason: that change introduces race conditions on CI.

PR Close #41707
AndrewKushnir added a commit that referenced this pull request Apr 19, 2021
@AndrewKushnir
Revert "test(zone.js): should invoke XHR task even onload handler thr…
26a0285 
…ow error. (#41562)" (#41707)

This reverts commit 6910118.

Reason: this change introduces race conditions on CI.

PR Close #41707
AndrewKushnir added a commit that referenced this pull request Apr 19, 2021
@AndrewKushnir
Revert "fix(zone.js): should continue to executue listeners when thro…
3631934 
…w error (#41562)" (#41707)

This reverts commit 5c48cd3.

Reason: that change introduces race conditions on CI.

PR Close #41707
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented May 20, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

2 participants

@AndrewKushnir @josephperrott