Repository navigation
Conversation
When a DOM element is disabled and an enabled control is set as input of its [formControl] directive, the DOM element will not be enabled.
ebiermann
force-pushed
the
form-control-enable
branch
from
April 14, 2021 06:04
679b65a to
f098118
Compare
Contributor
|
Hi @ebiermann, thanks for creating this PR. It looks like it's a duplicate of the #35311. The tricky part of this change is that it requires a breaking change, so it needs more research and transition plan/mechanics for applications. I'm closing this PR in favor of #35311, please subscribe to that PR for further updates. Thank you. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
When having a [formControl] directive with a disabled control and replacing it with an enabled one, the disabled flag of the corresponding DOM element is not removed. Technically ngOnChanges will only ever set the disabled state of its DOM element to true if the control is disabled instead of also removing the disabled flag if the control is enabled.
Issue Number: N/A
What is the new behavior?
When setting an enabled control as input of [formControl] the disabled attribute of its DOM element will be removed.
Does this PR introduce a breaking change?