fix(zone.js): update several flaky cases #41526
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JiaLiPassion
force-pushed
the
testcase-fix
branch
from
9d665ef to
da2beb2
Compare
Related to angular#41434 Fix several flaky cases. 1. should restore `window.onerror` in test cases. 2. expect().toThrow() should pass a function.
JiaLiPassion
force-pushed
the
testcase-fix
branch
from
da2beb2 to
b726f5e
Compare
alan-agius4
approved these changes
Jan 21, 2022
JiaLiPassion
added
action: merge
Contributor
|
This PR was merged into the repository by commit 25a83eb. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
josmar-crwdstffng
pushed a commit
to josmar-crwdstffng/angular
that referenced
this pull request
Apr 8, 2022
Related to angular#41434 Fix several flaky cases. 1. should restore `window.onerror` in test cases. 2. expect().toThrow() should pass a function. PR Close angular#41526
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #41434
Fix several flaky cases.
window.onerrorin test cases.