build: update several dependencies #41434

alan-agius4 · 2021-04-03T09:14:01Z

test: remove cli-hello-world-lazy-rollup tests

In version 12 of the Angular CLI the experimentalRollupPass has been removed.

build: update Angular CLI packages to 12.0.0-next.7

With this change we update Angular CLI packages that are used in the repo for testing to 12.0.0-next.7

test(ngcc): provide correct source-mappings for renderer tests

The recent update to MagicString, results in a different basic set of mappings in the renderer. This change updates our tests to match.

build(docs-infra): update dgeni-packages dependency

This update includes fixes that prevented us from updating
other dependencies.

ci: improve renovate configuration

With this change we add several packages to ignored ignoreDeps as these packages cannot be updated safely as they cause a large number of errors.

In addition, we add a group for remark packages.

build: update several dependencies

With this change we update several dependencies to avoid Renovate from create a lot of PRs during onboarding. We also remove yarn workspaces as after further analysis these are not needed.

Certain dependencies such as @octokit/rest, remark and @babel/* have not been updated as they require a decent amount of work to update, and it's best to leave them for a seperate PR.

petebacondarwin · 2021-04-06T12:03:00Z

@googlebot I consent.

alan-agius4 · 2021-04-07T08:52:31Z

Thanks to our Englishman (@petebacondarwin) for all the help in NGTSC and Dgeni.

alan-agius4 · 2021-04-07T09:18:30Z

Note: Once this lands you might experience "weird" errors when using ng-dev or some tests targets.

Example:

node_modules/@octokit/request/node_modules/@octokit/endpoint/dist-node/index.js:24
    if (isPlainObject(options[key])) {
        ^

TypeError: isPlainObject is not a function

This is related to incorrect module hoisting. Please run the below:

$ rm -rf node_modules aio/node_modules
$ yarn

Or even better, but make sure you don't have any untracked files as you will loose them.

$ git clean -dxf
$ yarn

josephperrott · 2021-04-07T14:17:06Z

packages/zone.js/test/common/zone.spec.ts

@JiaLiPassion Should this test be removed or reenabled?

Note: The reason why I didn’t spend time fixing the compile time error of this test is that it was disabled.

The case is not correct, So please just keep the case comment out, I will fix it later.

gkalpak

Yay! 🎉

renovate.json

scripts/puppeteer-chromedriver-versions.js

gkalpak · 2021-04-07T19:47:11Z

packages/zone.js/test/browser/browser.spec.ts

OOC, why this change?

Without these changes, this test failed. The default behaviour was not prevented which caused the error to bubble up.

@JiaLiPassion can you please take a look?

Just to be clear, I am not asking about the addition of evt.preventDefault() but the switch from arrow functions to regular functions.

Yeah, I know, both are needed.

I will fix this case and the related case laster, @alan-agius4 , could you please also comment out this case?

I disabled the test.

dev-infra/release/publish/test/github-api-testing.ts

goldens/size-tracking/aio-payloads.json

dev-infra/pr/merge/defaults/integration.spec.ts

package.json

gkalpak

BTW, there are a couple of commit message typos:

avoid Renovate from create --> avoid Renovate creating
add several package --> add several packages
updated safly --> updated safely

Julien-Marcou · 2021-04-08T10:32:31Z

Even though it is not required, I believe it would be better to update TypeScript to v4.2.4 for these files too, so it's easier to track TypeScript version usage for futur updates :

aio/aio-builds-setup/dockerbuild/scripts-js/package.json
aio/aio-builds-setup/dockerbuild/scripts-js/yarn.lock
integration/typings_test_ts42/package.json
packages/bazel/package.json
packages/compiler-cli/package.json
packages/zone.js/package.json
packages/zone.js/test/typings/package.json
packages/zone.js/yarn.lock

And also update packages/compiler-cli/src/typescript_support.ts with const MIN_TS_VERSION = '4.2.4';

josephperrott

LGTM

The recent update to MagicString, results in a different basic set of mappings in the renderer. This change updates our tests to match.

With this change we update Angular CLI packages that are used in the repo for testing to `12.0.0-next.7`

In version 12 of the Angular CLI the `experimentalRollupPass` has been removed.

This is a temporary workaround until the CLI version containing a fix for the regression caused by deacc74 is available on NPM. Without this change CLI builds will fail with; ``` angularCompiler.getNextProgram is not a function ```

In Angular CLI 12, application can only be compiled using Ivy, therefore we shouldn't run these tests when Bazel runs with View Engine context.

AndrewKushnir

Reviewed-for: size-tracking

With this change we add several packages to ignored `ignoreDeps` as these packages cannot be updated safely as they cause a large number of errors. In addition, we add a group for `remark` packages. PR Close #41434

This update includes fixes that prevented us from updating other dependencies. PR Close #41434

The recent update to MagicString, results in a different basic set of mappings in the renderer. This change updates our tests to match. PR Close #41434

With this change we update Angular CLI packages that are used in the repo for testing to `12.0.0-next.7` PR Close #41434

In version 12 of the Angular CLI the `experimentalRollupPass` has been removed. PR Close #41434

This is a temporary workaround until the CLI version containing a fix for the regression caused by deacc74 is available on NPM. Without this change CLI builds will fail with; ``` angularCompiler.getNextProgram is not a function ``` PR Close #41434

In Angular CLI 12, application can only be compiled using Ivy, therefore we shouldn't run these tests when Bazel runs with View Engine context. PR Close #41434

angular-automatic-lock-bot · 2021-05-14T16:08:17Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added the target: major This PR is targeted for the next major release label Apr 3, 2021

google-cla bot added the cla: yes label Apr 3, 2021

gkalpak self-requested a review April 3, 2021 12:11

atscott added the area: build & ci Related the build and CI infrastructure of the project label Apr 5, 2021

ngbot bot added this to the Backlog milestone Apr 5, 2021

alan-agius4 added the action: time-zone label Apr 6, 2021

This comment has been minimized.

Sign in to view

google-cla bot added cla: no and removed cla: yes labels Apr 6, 2021

google-cla bot added cla: yes and removed cla: no labels Apr 6, 2021

alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 7, 2021

alan-agius4 marked this pull request as ready for review April 7, 2021 08:49

pullapprove bot requested review from IgorMinar, JiaLiPassion and alxhub April 7, 2021 08:49

alan-agius4 requested review from josephperrott and removed request for IgorMinar April 7, 2021 08:50

josephperrott requested changes Apr 7, 2021

View reviewed changes

petebacondarwin approved these changes Apr 7, 2021

View reviewed changes

gkalpak suggested changes Apr 7, 2021

View reviewed changes

alan-agius4 mentioned this pull request Apr 8, 2021

build: update TypeScript to v4.2.4 #41494

Closed

14 tasks

alan-agius4 requested review from gkalpak and josephperrott April 8, 2021 07:27

josephperrott approved these changes Apr 8, 2021

View reviewed changes

petebacondarwin and others added 12 commits April 12, 2021 09:42

test(ngcc): provide correct source-mappings for renderer tests

378a1d7

The recent update to MagicString, results in a different basic set of mappings in the renderer. This change updates our tests to match.

build: update Angular CLI packages to 12.0.0-next.7

388035a

With this change we update Angular CLI packages that are used in the repo for testing to `12.0.0-next.7`

test: remove cli-hello-world-lazy-rollup tests

1b9366d

In version 12 of the Angular CLI the `experimentalRollupPass` has been removed.

fixup! ci: improve renovate configuration

031ce7e

fixup! build: update several dependencies

6e51ee1

fixup! build: update several dependencies

f5470e3

fixup! build: update several dependencies

9b1f7f9

fixup! build: update @angular-devkit/build-angular to use commit SHA

a83d88e

test: update CLI integration tests to run only for Ivy

d64a377

In Angular CLI 12, application can only be compiled using Ivy, therefore we shouldn't run these tests when Bazel runs with View Engine context.

fixup! build: update several dependencies

8e2b956

fixup! test: update CLI integration tests to run only for Ivy

8c11a39

alan-agius4 removed the state: blocked label Apr 12, 2021

AndrewKushnir approved these changes Apr 12, 2021

View reviewed changes

alan-agius4 removed request for atscott, jelbourn and jessicajaniuk April 12, 2021 17:31

alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 12, 2021

zarend closed this in ed7d288 Apr 12, 2021

zarend pushed a commit that referenced this pull request Apr 12, 2021

build(docs-infra): update dgeni-packages dependency (#41434)

5600df2

This update includes fixes that prevented us from updating other dependencies. PR Close #41434

zarend pushed a commit that referenced this pull request Apr 12, 2021

build: update Angular CLI packages to 12.0.0-next.7 (#41434)

1c82eff

With this change we update Angular CLI packages that are used in the repo for testing to `12.0.0-next.7` PR Close #41434

zarend pushed a commit that referenced this pull request Apr 12, 2021

test: remove cli-hello-world-lazy-rollup tests (#41434)

28f1e1c

In version 12 of the Angular CLI the `experimentalRollupPass` has been removed. PR Close #41434

alan-agius4 deleted the packages-update branch April 13, 2021 05:21

angular-automatic-lock-bot bot locked and limited conversation to collaborators May 14, 2021

build: update several dependencies #41434

build: update several dependencies #41434

Uh oh!

Conversation

alan-agius4 commented Apr 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

petebacondarwin commented Apr 6, 2021

Uh oh!

alan-agius4 commented Apr 7, 2021

Uh oh!

alan-agius4 commented Apr 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JiaLiPassion Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gkalpak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julien-Marcou commented Apr 8, 2021

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

AndrewKushnir left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented May 14, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

alan-agius4 commented Apr 3, 2021 •

edited

Loading

alan-agius4 commented Apr 7, 2021 •

edited

Loading

JiaLiPassion Apr 8, 2021 •

edited

Loading

gkalpak left a comment •

edited

Loading