-
Notifications
You must be signed in to change notification settings - Fork 27.2k
fix(docs-infra): several angular.io fixes for IE11 #41183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d99d054
4043319
ec64a5a
100a4c7
9bb0cde
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /** | ||
| * Custom Elements polyfills for browsers that natively support Custom Elements but not ES2015 | ||
| * modules. | ||
| * | ||
| * NOTE: | ||
| * Chrome, Firefox and Safari should not need these, because they added support for ES2015 modules | ||
| * before Custom Elements. It is still required for some other (less common) browsers: | ||
| * - UC browser for android 11.8 (~3.5% global usage) | ||
| * - Samsung browser 5.0-8.1 (~0.43% global usage) | ||
| * - Opera 41-47 (~0.02% global usage) | ||
| */ | ||
| // @ts-nocheck | ||
|
|
||
| require('core-js/modules/es.reflect.construct'); // Required by `native-shim.js`. | ||
| require('@webcomponents/custom-elements/src/native-shim'); |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,8 @@ | |
| } | ||
|
|
||
| .sidenav-content { | ||
| display: block; // This is required for browsers that do not recognize `<main>` as a block | ||
| // element (such as IE11). | ||
|
Comment on lines
+7
to
+8
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you not fix this generically by adding a rule like? main {
display: block;
}
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I could (but since we don't have (nor is it very likely to have) another Of course, a rule targeting Both are unlikely to happen (esp. before we drop support for IE11), so I went with the least amount of loc 😁 |
||
| min-height: 100vh; | ||
| padding: 80px 3rem 2rem; | ||
| max-width: 50em; | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet more dependencies! Was this not possible with some of the tools that we already depend upon, like Babel and webpack?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't directly depend on Babel or Webpack in AIO 🤷♂️
So, if we are going to add new direct dependencies, it is so much cooler (and probably faster) to use state of the art tools, such as
esbuildandswc💪 😛