fix(dev-infra): detect multiple target labels as invalid#40156
fix(dev-infra): detect multiple target labels as invalid#40156josephperrott wants to merge 3 commits intoangular:masterfrom
Conversation
When multiple target labels are applied to a PR, it should be considered invalid as our tooling does not support a single PR targetting multiple trains/versions.
josephperrott
added
action: review
There was a problem hiding this comment.
our tooling does not support a single PR targetting multiple trains/versions
I think this part of the commit sounds a little confusing. We do support merging into multiple trains/versions. For example, the target: patch label could result in merging into master, RC and patch. The commit message could be a little more clear on what the tooling does not support (multiple target labels?).
Otherwise lgtm 👍
gkalpak
left a comment
gkalpak
left a comment
There was a problem hiding this comment.
LGTM (as soon as CI is happy) 🚀
josephperrott
added
action: merge
When multiple target labels are applied to a PR, it should be considered invalid as our tooling does not support a single PR targetting multiple trains/versions. PR Close #40156
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
When multiple target labels are applied to a PR, it should be considered
invalid as our tooling does not support a single PR targetting multiple
trains/versions.