fix(core): set ngDevMode to false when calling enableProdMode()#40124
Closed
alan-agius4 wants to merge 1 commit intoangular:masterfrom
alan-agius4:prod-mode-ng-dev-mode
Closed
fix(core): set ngDevMode to false when calling enableProdMode()#40124alan-agius4 wants to merge 1 commit intoangular:masterfrom alan-agius4:prod-mode-ng-dev-mode
ngDevMode to false when calling enableProdMode()#40124alan-agius4 wants to merge 1 commit intoangular:masterfrom
alan-agius4:prod-mode-ng-dev-mode
Conversation
alan-agius4
added
action: review
The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`. https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case.
Contributor
Author
Contributor
mhevery
approved these changes
Dec 15, 2020
alan-agius4
added
action: merge
kyliau
added
the
target: lts
Contributor
AndrewKushnir
removed
the
action: presubmit
Contributor
|
FYI, presubmit went well for the changes in this PR. @kyliau @alan-agius4 there are 2 target labels on this PR and the tooling does not support a single PR targeting multiple Thank you. |
AndrewKushnir
removed
the
target: lts
Contributor
Author
|
Thanks @AndrewKushnir, I’ll create the PRs to target LTS branches tomorrow as I don’t have access to my laptop at the moment. |
Contributor
alxhub
pushed a commit
that referenced
this pull request
Dec 16, 2020
…#40124) The `ngDevMode` description also mentions that calling `enableProdMode` will set this the value to `false`. https://github.com/angular/angular/blob/4610093c87975b6355f31a9c849351129908783a/packages/core/src/util/ng_dev_mode.ts#L22 which is currently not the case. PR Close #40124
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the global
ngDevModeis set to false when using the Angular CLIoptimizationoption. This option sets the globals via terser using the Compiler CLI private tooling APIangular/packages/compiler-cli/src/tooling.ts
Lines 25 to 34 in d39d64c
It is not documented that users not using the Angular CLI or using Angular Universal without
optimizationneed to manually set tofalseas otherwise they will be vulnerable to XHR attacks.The
ngDevModedescription also mentions that callingenableProdModewill set the value tofalse.angular/packages/core/src/util/ng_dev_mode.ts
Line 22 in 4610093
Closes #37644