Repository navigation
test(docs-infra): add unit tests for rxjs examples - #38905
Closed
sonukapoor wants to merge 4 commits into
Closed
sonukapoor wants to merge 4 commits into
sonukapoor wants to merge 4 commits into
Conversation
sonukapoor
marked this pull request as ready for review
September 19, 2020 12:42
sonukapoor
added
comp: docs-infra
refactoring
sonukapoor
added
the
target: patch
gkalpak
added
the
action: review
gkalpak
suggested changes
Sep 19, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Thx, @sonukappor!
Awesome to see that these tests provide immediate value by finding broken examples (such as the retry-on-error one) 🎉
Please update the commit message to mention that this PR is targeting the rx-library example specifically.
gkalpak
added
state: WIP
and removed
action: review
sonukapoor
force-pushed
the
unit-tests-for-rx-library
branch
3 times, most recently
from
September 20, 2020 14:03
62fc8a4 to
79741b1
Compare
sonukapoor
force-pushed
the
unit-tests-for-rx-library
branch
4 times, most recently
from
September 20, 2020 23:26
c19bc48 to
015e251
Compare
gkalpak
suggested changes
Sep 21, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
Reminder to self: #38905 (comment) is still pending.
sonukapoor
force-pushed
the
unit-tests-for-rx-library
branch
from
September 22, 2020 00:02
49c8389 to
e7a7160
Compare
sonukapoor
force-pushed
the
unit-tests-for-rx-library
branch
from
September 22, 2020 12:02
e7a7160 to
5cda081
Compare
gkalpak
suggested changes
Sep 25, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
#38905 (comment) doesn't seem to have been addressed.
Reminder to self: #38905 (comment) is still pending.
gkalpak
suggested changes
Sep 27, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
#38905 (comment) doesn't seem to have been addressed.
Reminder to self: #38905 (comment) is still pending.
This commit adds missing unit tests for all rx-library examples from the docs. Closes angular#28017
This commit adds an extra test for the `retry-on-error` snippet of the `rx-library` docs example to ensure it can successfully recover after a couple of failed attempts. This commit addresses comment angular#38905 (comment).
gkalpak
force-pushed
the
unit-tests-for-rx-library
branch
from
September 28, 2020 16:35
30a7212 to
e0e139d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
gkalpak
approved these changes
Sep 28, 2020
gkalpak
left a comment
gkalpak
left a comment
Member
There was a problem hiding this comment.
LGTM 
Thank you, @sonukapoor, for getting everything sorted out ❤️
Reviewed-for: global-docs-approvers
gkalpak
added
action: cleanup
Member
|
@sonukapoor: FYI, I rebased this on master, squashed fixup commits, added a new fixup commit with some minor clean-up and added a new commit with the test we discussed in #38905 (comment). Please, take a look and confirm this looks good to you 👀 |
Contributor
Author
LGTM. Thanks @gkalpak |
gkalpak
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Sep 28, 2020
alxhub
pushed a commit
that referenced
this pull request
Sep 28, 2020
…38905) This commit adds an extra test for the `retry-on-error` snippet of the `rx-library` docs example to ensure it can successfully recover after a couple of failed attempts. This commit addresses comment #38905 (comment). PR Close #38905
alxhub
pushed a commit
that referenced
this pull request
Sep 28, 2020
Previously, the `retry` example did not work as intended. The `retry` operator was called before the exception occured, thus not retrying the `ajax` request. This commit moves the `retry` operator into the correct order to ensure that the failed request is retried. PR Close #38905
alxhub
pushed a commit
that referenced
this pull request
Sep 28, 2020
alxhub
pushed a commit
that referenced
this pull request
Sep 28, 2020
…38905) This commit adds an extra test for the `retry-on-error` snippet of the `rx-library` docs example to ensure it can successfully recover after a couple of failed attempts. This commit addresses comment #38905 (comment). PR Close #38905
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds missing unit tests for all rxjs examples from the docs.
Closes #28017
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?