Skip to content

chore(build): Add Microsoft Edge launcher; add it to CI - #3888

Closed
mgol wants to merge 1 commit into
angular:masterfrom
mgol:edge
Closed

mgol wants to merge 1 commit into
angular:masterfrom
mgol:edge

Conversation

@mgol

@mgol mgol commented Aug 28, 2015

Copy link
Copy Markdown
Member

Note that until Karma gets updated to >=0.13.0, Edge results will be logged
as Chrome's (v39 or v42).

@mgol

mgol commented Aug 28, 2015

Copy link
Copy Markdown
Member Author

OK, I get:

ERROR [launcher.sauce]: Can not start microsoftedge (Windows 10)
  [init({"selenium-version":"2.45.0","command-timeout":600,"idle-timeout":600,"max-duration":5400,"base":"SauceLabs","browserName":"microsoftedge","platform":"Windows 10","version":"","tags":[],"name":"Angular2","tunnel-identifier":"9038.3","record-video":false,"record-screenshots":false,"build":"TRAVIS #9038 (77692599)","device-orientation":null,"disable-popup-handler":true})] The environment you requested was unavailable.
  {"status": 13, "sessionId": "f5c94a7f045f4335b2b0df70e6f5cc5e", "value": {"message": "The Sauce VMs failed to start the browser or device\nFor more info, please check https://docs.saucelabs.com/reference/troubleshooting-common-error-messages"}}

According to Sauce docs this is most likely due to a mismatched Selenium version. I'd guess it has to be updated to v2.46 to make it work but Protractor requires 2.45.1 currently. So this is probably not going to fly until angular/protractor#2377 is fixed in Protractor.

@pkozlowski-opensource

Copy link
Copy Markdown
Member

AFAIK edge was added to SauceLabs recently. @mzgol could you re-base / re-push your PR to check?

Note that until Karma gets updated to >=0.13.0, Edge results will be logged
as Chrome's (v39 or v42).
@mgol

mgol commented Sep 16, 2015

Copy link
Copy Markdown
Member Author

@pkozlowski-opensource Done. However, I think Sauce Labs already had Edge in the API when I submitted this PR so the error was most likely caused by what I wrote - a too old Selenium version enforced.

I'm not able to see anything in this test run, though, as the build is completely broken on Firefox & spits out so many errors that it stops: https://travis-ci.org/angular/angular/jobs/80625546.

@tbosch

tbosch commented Sep 28, 2015

Copy link
Copy Markdown
Contributor

@mzgol ping?

@mgol

mgol commented Sep 29, 2015

Copy link
Copy Markdown
Member Author

@tbosch Pong. :) I think this PR needs to wait for a webdriver update from 2.45.1 to 2.47 as Sauce Labs apparently doesn't support Edge with older versions. This may mean we need to wait at least for the next Protractor version as well (although I'm not 100% sure).

@marclaval

Copy link
Copy Markdown
Contributor

The same update is being tried in #4260, but the webdriver update is not enough, see the discussion there.

@mgol

mgol commented Sep 29, 2015

Copy link
Copy Markdown
Member Author

OK, I guess I'll close this PR then as the other one has more discussion and it's still not everything that's needed anyway.

@mgol mgol closed this Sep 29, 2015
@mgol
mgol deleted the edge branch December 28, 2015 20:37
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants