Repository navigation
Conversation
AndrewKushnir
added
area: forms
action: review
AndrewKushnir
requested changes
Jul 13, 2020
AndrewKushnir
left a comment
AndrewKushnir
left a comment
Contributor
There was a problem hiding this comment.
Thanks for performing this refactoring @benbraou 👍
I've left a few comments, please have a look when you get a chance.
I think it'd also be great to add some light-weight docs (describing what the function does and what arguments are) for all exported functions in the util.ts file.
Thank you.
A util file is added to forms test package: - it exposes simpleAsyncValidator, asyncValidator and asyncValidatorReturningObservable validators - it refactors simpleAsyncValidator and asyncValidator to use common promise creation code - it exposes currentStateOf allowing to get the validation state of a list of AbstractControl Closes angular#37831
Contributor
Author
|
Thank you for the review @AndrewKushnir 🙏. I updated the PR accordingly |
AndrewKushnir
approved these changes
Jul 22, 2020
Contributor
There was a problem hiding this comment.
Thanks for the updates @benbraou, the changes look great 👍
AndrewKushnir
added
action: merge
mhevery
added
target: major
mhevery
pushed a commit
to mhevery/angular
that referenced
this pull request
Jul 23, 2020
…ar#38020) A util file is added to forms test package: - it exposes simpleAsyncValidator, asyncValidator and asyncValidatorReturningObservable validators - it refactors simpleAsyncValidator and asyncValidator to use common promise creation code - it exposes currentStateOf allowing to get the validation state of a list of AbstractControl Closes angular#37831 PR Close angular#38020
Splaktar
pushed a commit
to angular-hispano/angular
that referenced
this pull request
Aug 8, 2020
…ar#38020) A util file is added to forms test package: - it exposes simpleAsyncValidator, asyncValidator and asyncValidatorReturningObservable validators - it refactors simpleAsyncValidator and asyncValidator to use common promise creation code - it exposes currentStateOf allowing to get the validation state of a list of AbstractControl Closes angular#37831 PR Close angular#38020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
…ar#38020) A util file is added to forms test package: - it exposes simpleAsyncValidator, asyncValidator and asyncValidatorReturningObservable validators - it refactors simpleAsyncValidator and asyncValidator to use common promise creation code - it exposes currentStateOf allowing to get the validation state of a list of AbstractControl Closes angular#37831 PR Close angular#38020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
asyncValidatoris duplicated across multiple form test files.Issue Number: N/A
#37831
What is the new behavior?
A util file is added to forms test package:
simpleAsyncValidator,asyncValidatorandasyncValidatorReturningObservablevalidatorssimpleAsyncValidatorandasyncValidatorto use common promise creation codecurrentStateOfallowing to get the validation state of a list ofAbstractControlDoes this PR introduce a breaking change?
Other information