Skip to content

docs(zone.js): update zone.js bundle doc since the APF change#37919

Closed
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:zone-bundle-doc
Closed

docs(zone.js): update zone.js bundle doc since the APF change#37919
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion:zone-bundle-doc

Conversation

@JiaLiPassion
Copy link
Copy Markdown
Contributor

@JiaLiPassion JiaLiPassion commented Jul 3, 2020

Since the PR #36540 change the zone.js bundles to Angular Package Format, the
bundle name/location are changed, so this PR updated the README.md doc for the
zone bundles.
Also add the recent added new bundles zone-patch-message-port doc.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

@JiaLiPassion JiaLiPassion requested a review from mhevery July 3, 2020 23:57
@JiaLiPassion JiaLiPassion added area: zones Issues related to zone.js target: major This PR is targeted for the next major release labels Jul 7, 2020
@ngbot ngbot bot modified the milestone: needsTriage Jul 7, 2020
mhevery
mhevery suggested changes Jul 10, 2020
View reviewed changes
packages/zone.js/README.md Outdated
Copy link
Copy Markdown
Contributor

@mhevery mhevery Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it removing Error support or adding? I would think it would add error support, so the text is confusing.

Copy link
Copy Markdown
Contributor Author

@JiaLiPassion JiaLiPassion Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it is confusing, I have updated the text to

|`zone-error.js`|patch for `Error Global Object`, supports adding zone information to stack frame, and also removing unrelated stack frames from `zone.js` internally|

mhevery
mhevery approved these changes Jul 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

69c771a48e contains my fixes

packages/zone.js/README.md Outdated
Copy link
Copy Markdown
Contributor

@mhevery mhevery Jul 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what additional patches does it include in legacy?

Copy link
Copy Markdown
Contributor Author

@JiaLiPassion JiaLiPassion Jul 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now there are two patches in legacy bundle.

  1. the old Web Components registerElement patch.
  2. some old browsers not support EventTarget interface, so we have to patch all the APIs such as HTMLElement one by one.

@mhevery mhevery added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 10, 2020
@JiaLiPassion
docs(zone.js): update zone.js bundle doc since the APF change
f45fa5b 
Since the PR angular#36540 change the zone.js bundles to Angular Package Format, the
bundle name/location are changed, so this PR updated the `README.md` doc for the
zone bundles.
Also add the recent added new bundles `zone-patch-message-port` doc.
@JiaLiPassion JiaLiPassion removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Jul 14, 2020
@mhevery mhevery added the action: merge The PR is ready for merge by the caretaker label Jul 24, 2020
@mhevery mhevery closed this in 6a3e68b Jul 24, 2020
Splaktar pushed a commit to angular-hispano/angular that referenced this pull request Aug 8, 2020
@JiaLiPassion @Splaktar
docs(zone.js): update zone.js bundle doc since the APF change (angula…
f020941 
…r#37919)

Since the PR angular#36540 change the zone.js bundles to Angular Package Format, the
bundle name/location are changed, so this PR updated the `README.md` doc for the
zone bundles.
Also add the recent added new bundles `zone-patch-message-port` doc.

PR Close angular#37919
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Aug 24, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 24, 2020
profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
@JiaLiPassion @profanis
docs(zone.js): update zone.js bundle doc since the APF change (angula…
6459a3e 
…r#37919)

Since the PR angular#36540 change the zone.js bundles to Angular Package Format, the
bundle name/location are changed, so this PR updated the `README.md` doc for the
zone bundles.
Also add the recent added new bundles `zone-patch-message-port` doc.

PR Close angular#37919
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhevery mhevery mhevery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@JiaLiPassion @mhevery @googlebot