Repository navigation
fix(forms): fix enabling form control after it was disabled - #36227
Closed
sonukapoor wants to merge 1 commit into
Closed
sonukapoor wants to merge 1 commit into
sonukapoor wants to merge 1 commit into
Conversation
Previously, it was not possible to enable a form control after it was disabled. This commit fixes this by making sure that the form is enabled and that `setDisabledState` is called with `false`. Closes angular#35565
sonukapoor
force-pushed
the
form-toggle-enable-disable-fix
branch
from
March 24, 2020 14:10
2a539c8 to
7f07bf2
Compare
Member
Contributor
Author
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it was not possible to enable a form control after it was disabled.
This commit fixes this by making sure that the form is enabled and that
setDisabledStateis called withfalse.Closes #35565
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #35565
What is the new behavior?
Does this PR introduce a breaking change?
Other information