Repository navigation
Conversation
This commit makes `findOutputBinding` a utility function for the language service, which will be used by the `expression_diagnostics` module in angular#34570. Keeping the function in `locate_symbol` results in a circular dependency between `expression_diagnostics` and `locate_symbol`.
ayazhafiz
added
refactoring
kyliau
approved these changes
Jan 27, 2020
AndrewKushnir
pushed a commit
that referenced
this pull request
Jan 27, 2020
…#34997) This commit makes `findOutputBinding` a utility function for the language service, which will be used by the `expression_diagnostics` module in #34570. Keeping the function in `locate_symbol` results in a circular dependency between `expression_diagnostics` and `locate_symbol`. PR Close #34997
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes
findOutputBindinga utility function for thelanguage service, which will be used by the
expression_diagnosticsmodule in #34570. Keeping the function in
locate_symbolresults in acircular dependency between
expression_diagnosticsandlocate_symbol.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?