Skip to content

refactor(language-service): cleanup of low-hanging TODOs - #34784

Closed
ayazhafiz wants to merge 2 commits into
angular:masterfrom
ayazhafiz:i/typeargs
Closed

refactor(language-service): cleanup of low-hanging TODOs#34784
ayazhafiz wants to merge 2 commits into
angular:masterfrom
ayazhafiz:i/typeargs

Conversation

@ayazhafiz

@ayazhafiz ayazhafiz commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

Cleans up some simple TODOs. Also removes
typescript_symbols#getTypeWrapper, which I thought I had but failed to
remove in #34571.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

Does this PR introduce a breaking change?

  • Yes
  • No

@ayazhafiz ayazhafiz added refactoring Issue that involves refactoring or code-cleanup area: language-service Issues related to Angular's VS Code language service labels Jan 15, 2020
@ayazhafiz
ayazhafiz requested review from a team and kyliau January 15, 2020 06:50
@ngbot ngbot Bot added this to the needsTriage milestone Jan 15, 2020
@kyliau kyliau added the target: patch This PR is targeted for the next patch release label Jan 15, 2020
@ayazhafiz
refactor(language-service): cleanup of low-hanging TODOs
a94658b 
Cleans up some simple TODOs. Also removes
`typescript_symbols#getTypeWrapper`, which I thought I had but failed to
remove in angular#34571.
@ayazhafiz ayazhafiz added the action: merge The PR is ready for merge by the caretaker label Jan 18, 2020
@matsko matsko closed this in 6c8e322 Jan 21, 2020
matsko pushed a commit that referenced this pull request Jan 21, 2020
@ayazhafiz @matsko
refactor(language-service): cleanup of low-hanging TODOs (#34784)
4242c43 
Cleans up some simple TODOs. Also removes
`typescript_symbols#getTypeWrapper`, which I thought I had but failed to
remove in #34571.

PR Close #34784
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Feb 21, 2020

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kyliau kyliau kyliau approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service cla: yes refactoring Issue that involves refactoring or code-cleanup target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

3 participants

@ayazhafiz @kyliau @googlebot