Repository navigation
Conversation
ayazhafiz
added
refactoring
4 of 6 tasks
andrius-pra
reviewed
Jan 5, 2020
kyliau
suggested changes
Jan 10, 2020
Adds a `typeArguments` method to the `Symbol` interface, cleaning up how type parameters of a TypeScript type are currently found. This will be necessary for providing completions for `$event` variables' properties (angular#34570). This commit also performs some fly-by cleanups seen while implementing the `typeArguments` methods. There is more clean up to do in the `typescript_symbols` file, but the scope of this commit didn't need to get larger.
ayazhafiz
force-pushed
the
e/symbol-type-parameter
branch
from
January 13, 2020 22:52
311a6ee to
6c7a99c
Compare
kyliau
approved these changes
Jan 13, 2020
atscott
pushed a commit
that referenced
this pull request
Jan 13, 2020
#34571) Adds a `typeArguments` method to the `Symbol` interface, cleaning up how type parameters of a TypeScript type are currently found. This will be necessary for providing completions for `$event` variables' properties (#34570). This commit also performs some fly-by cleanups seen while implementing the `typeArguments` methods. There is more clean up to do in the `typescript_symbols` file, but the scope of this commit didn't need to get larger. PR Close #34571
3 of 6 tasks
ayazhafiz
added a commit
to ayazhafiz/angular
that referenced
this pull request
Jan 18, 2020
Cleans up some simple TODOs. Also removes `typescript_symbols#getTypeWrapper`, which I thought I had but failed to remove in angular#34571.
matsko
pushed a commit
that referenced
this pull request
Jan 21, 2020
matsko
pushed a commit
that referenced
this pull request
Jan 21, 2020
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
typeArgumentsmethod to theSymbolinterface, cleaning up howtype parameters of a TypeScript type are currently found. This will be
necessary for providing completions for
$eventvariables' properties(#34570).
This commit also performs some fly-by cleanups seen while implementing
the
typeArgumentsmethods. There is more clean up to do in thetypescript_symbolsfile, but the scope of this commit didn't need toget larger.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?