feat(language-service): completions for output $event properties by ayazhafiz · Pull Request #34570 · angular/angular

ayazhafiz · 2019-12-26T19:47:50Z

This commit adds support for completions of properties on $event
variables in bound outputs.

This is the second major PR to support completions for $event
variables (angular/vscode-ng-language-service#531).
The final completion support that must be provided is for $event
variables in bindings targeting DOM events, like (click).

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Feature

Does this PR introduce a breaking change?

Yes
No

ayazhafiz · 2019-12-26T21:58:18Z

Blocked by

Adds a `typeArguments` method to the `Symbol` interface, cleaning up how type parameters of a TypeScript type are currently found. This will be necessary for providing completions for `$event` variables' properties (angular#34570). This commit also performs some fly-by cleanups seen while implementing the `typeArguments` methods. There is more clean up to do in the `typescript_symbols` file, but the scope of this commit didn't need to get larger.

#34571) Adds a `typeArguments` method to the `Symbol` interface, cleaning up how type parameters of a TypeScript type are currently found. This will be necessary for providing completions for `$event` variables' properties (#34570). This commit also performs some fly-by cleanups seen while implementing the `typeArguments` methods. There is more clean up to do in the `typescript_symbols` file, but the scope of this commit didn't need to get larger. PR Close #34571

kyliau · 2020-01-21T21:12:40Z

we could pull it out into utils.ts (in subsequent PR).

I will make a PR to fix this later today, as it is blocking the CI tests.

cool, I'll mark this PR as blocked for now. Thanks!

ayazhafiz · 2020-01-24T02:18:34Z

@andrius-pra if you would like to review

kyliau

It looks like some comments were resolved but the updates were not reflected in the code. Could you please double check?

ayazhafiz · 2020-01-27T18:56:40Z

It looks like some comments were resolved but the updates were not reflected in the code. Could you please double check?

My bad; should be pushed up now.

This commit makes `findOutputBinding` a utility function for the language service, which will be used by the `expression_diagnostics` module in angular#34570. Keeping the function in `locate_symbol` results in a circular dependency between `expression_diagnostics` and `locate_symbol`.

…#34997) This commit makes `findOutputBinding` a utility function for the language service, which will be used by the `expression_diagnostics` module in #34570. Keeping the function in `locate_symbol` results in a circular dependency between `expression_diagnostics` and `locate_symbol`. PR Close #34997

This commit adds a completion for the `$event` variable in bound event expressions. This is the first in a series of PRs to support completions for properties on `$event` variables (angular/vscode-ng-language-service#531).

This commit adds support for completions of properties on `$event` variables in bound outputs. This is the second major PR to support completions for `$event` variables (angular/vscode-ng-language-service#531). The final completion support that must be provided is for `$event` variables in bindings targeting DOM events, like `(click)`.

…es in

…34570) This commit adds support for completions of properties on `$event` variables in bound outputs. This is the second major PR to support completions for `$event` variables (angular/vscode-ng-language-service#531). The final completion support that must be provided is for `$event` variables in bindings targeting DOM events, like `(click)`. PR Close #34570

This commit adds a completion for the `$event` variable in bound event expressions. This is the first in a series of PRs to support completions for properties on `$event` variables (angular/vscode-ng-language-service#531). PR Close #34570

…34570) This commit adds support for completions of properties on `$event` variables in bound outputs. This is the second major PR to support completions for `$event` variables (angular/vscode-ng-language-service#531). The final completion support that must be provided is for `$event` variables in bindings targeting DOM events, like `(click)`. PR Close #34570

angular-automatic-lock-bot · 2020-02-28T16:08:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Dec 26, 2019

ayazhafiz changed the title ~~I/$event type~~ feat(language-service): completions for output $event properties Dec 26, 2019

ayazhafiz added the state: blocked label Dec 26, 2019

ayazhafiz mentioned this pull request Dec 26, 2019

refactor(language-service): adds Symbol#typeArguments and does cleanup #34571

Closed

4 of 7 tasks

andrius-pra reviewed Jan 3, 2020

View reviewed changes

Comment thread packages/language-service/test/completions_spec.ts Resolved

andrius-pra reviewed Jan 3, 2020

View reviewed changes

Comment thread packages/language-service/src/expression_diagnostics.ts Resolved

andrius-pra mentioned this pull request Jan 3, 2020

feat(language-service): Completions for custom-event bindings #32085

Closed

4 of 14 tasks

atscott added the area: language-service Issues related to Angular's VS Code language service label Jan 9, 2020

ngbot Bot added this to the needsTriage milestone Jan 9, 2020

ayazhafiz force-pushed the i/$event-type branch from 2da0536 to ad95e34 Compare January 18, 2020 17:39

ayazhafiz marked this pull request as ready for review January 18, 2020 17:39

ayazhafiz requested review from a team and kyliau January 18, 2020 17:39

ayazhafiz added target: patch This PR is targeted for the next patch release feature Label used to distinguish feature request from other issues and removed state: blocked labels Jan 23, 2020

ayazhafiz force-pushed the i/$event-type branch from 160eb35 to 3042791 Compare January 23, 2020 03:27

kyliau suggested changes Jan 23, 2020

View reviewed changes

ayazhafiz force-pushed the i/$event-type branch from cde74fb to 824ec1f Compare January 24, 2020 02:17

ayazhafiz requested a review from kyliau January 24, 2020 02:18

ayazhafiz force-pushed the i/$event-type branch from 824ec1f to 5ed0d29 Compare January 25, 2020 17:48

kyliau suggested changes Jan 27, 2020

View reviewed changes

ayazhafiz force-pushed the i/$event-type branch from d8c0c1d to eb1b53e Compare January 27, 2020 18:56

ayazhafiz requested a review from kyliau January 27, 2020 18:56

kyliau added the state: blocked label Jan 27, 2020

ayazhafiz mentioned this pull request Jan 27, 2020

refactor(language-service): make findOutputBinding a utility function #34997

Closed

3 of 6 tasks

ayazhafiz and others added 8 commits January 27, 2020 15:55

feat(language-service): provide completion for $event variable

1b853ff

This commit adds a completion for the `$event` variable in bound event expressions. This is the first in a series of PRs to support completions for properties on `$event` variables (angular/vscode-ng-language-service#531).

fixup! feat(language-service): completions for output $event properti…

c925ae6

…es in

fixup! feat(language-service): completions for output $event properti…

b796300

…es in

fixup! feat(language-service): completions for output $event properti…

6ce57fb

…es in

fixup! feat(language-service): completions for output $event properti…

bcd5883

…es in

fixup! feat(language-service): completions for output $event properti…

6ffd523

…es in

fixup! feat(language-service): completions for output $event properti…

2b0175b

…es in

ayazhafiz force-pushed the i/$event-type branch from 4531ec5 to 2b0175b Compare January 28, 2020 00:24

ayazhafiz removed the state: blocked label Jan 28, 2020

kyliau approved these changes Jan 28, 2020

View reviewed changes

ayazhafiz added the action: merge The PR is ready for merge by the caretaker label Jan 28, 2020

AndrewKushnir closed this in 24864ee Jan 28, 2020

kyliau mentioned this pull request Jan 30, 2020

intellisense for $event in the html Template doesn't work angular/vscode-ng-language-service#531

Closed

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 28, 2020

Navigation Menu

Repository navigation

feat(language-service): completions for output $event properties - #34570

feat(language-service): completions for output $event properties#34570
ayazhafiz wants to merge 8 commits into
angular:masterfrom
ayazhafiz:i/$event-type

ayazhafiz commented Dec 26, 2019 •

edited

Loading

Uh oh!

ayazhafiz commented Dec 26, 2019 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyliau Jan 21, 2020

Uh oh!

ayazhafiz Jan 27, 2020

Uh oh!

kyliau Jan 27, 2020

Uh oh!

Uh oh!

ayazhafiz commented Jan 24, 2020

Uh oh!

kyliau left a comment

Uh oh!

ayazhafiz commented Jan 27, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Feb 28, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

ayazhafiz commented Dec 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

Does this PR introduce a breaking change?

Uh oh!

ayazhafiz commented Dec 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kyliau Jan 21, 2020

Choose a reason for hiding this comment

Uh oh!

ayazhafiz Jan 27, 2020

Choose a reason for hiding this comment

Uh oh!

kyliau Jan 27, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ayazhafiz commented Jan 24, 2020

Uh oh!

kyliau left a comment

Choose a reason for hiding this comment

Uh oh!

ayazhafiz commented Jan 27, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Feb 28, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ayazhafiz commented Dec 26, 2019 •

edited

Loading

ayazhafiz commented Dec 26, 2019 •

edited

Loading