Repository navigation
Conversation
ayazhafiz
added
feature
4 of 6 tasks
kyliau
suggested changes
Jan 9, 2020
kyliau
added
the
action: cleanup
Contributor
|
Could you please rerun circle CI? the test status seems to be stale |
ayazhafiz
force-pushed
the
i/$event-completion
branch
from
January 10, 2020 21:19
813290a to
803758d
Compare
Contributor
|
Contributor
Author
|
Forgot about that. Thanks. |
ayazhafiz
force-pushed
the
i/$event-completion
branch
from
January 10, 2020 23:39
acf49b6 to
97ec21c
Compare
Contributor
Author
|
@kyliau ptal |
kyliau
added
action: merge
kyliau
approved these changes
Jan 13, 2020
Contributor
|
Hi @ayazhafiz, can you rebase and resolve the merge conflict? Thanks! |
ayazhafiz
force-pushed
the
i/$event-completion
branch
from
January 13, 2020 23:27
97ec21c to
3e45d12
Compare
Contributor
|
Sorry @ayazhafiz! I merged another PR that conflicted with this one. Can you rebase again? |
This commit adds a completion for the `$event` variable in bound event expressions. This is the first in a series of PRs to support completions for properties on `$event` variables (angular/vscode-ng-language-service#531).
ayazhafiz
force-pushed
the
i/$event-completion
branch
from
January 14, 2020 23:27
3e45d12 to
a883ee5
Compare
atscott
pushed a commit
that referenced
this pull request
Jan 14, 2020
This commit adds a completion for the `$event` variable in bound event expressions. This is the first in a series of PRs to support completions for properties on `$event` variables (angular/vscode-ng-language-service#531). PR Close #34566
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a completion for the
$eventvariable in bound eventexpressions.
This is the first in a series of PRs to support completions for
properties on
$eventvariables (angular/vscode-ng-language-service#531).PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?