fix(docs-infra): convert hard-coded `comparing-observables` examples into a proper mini-app by sonukapoor · Pull Request #34327 · angular/angular

sonukapoor · 2019-12-10T14:50:14Z

…stable files

It also updates some indention issues with the code that is part of inline tables.

Fixes #31024

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: #31024

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

mary-poppins · 2019-12-12T11:00:41Z

You can preview dc19af6 at https://pr34327-dc19af6.ngbuilds.io/.
You can preview fd0d3ac at https://pr34327-fd0d3ac.ngbuilds.io/.

gkalpak

Off to a great start 🎉
Some more fine-tuning and this should be good to go!

(BTW, why the empty main.ts file?)

mary-poppins · 2019-12-12T21:14:11Z

You can preview 9def4e8 at https://pr34327-9def4e8.ngbuilds.io/.

gkalpak

Shaping up nicely ✨
I left a few more comments (nothing major).

mary-poppins · 2019-12-13T15:25:37Z

You can preview dd1e075 at https://pr34327-dd1e075.ngbuilds.io/.

gkalpak

Almost there 🎉

Can you please take care of #34327 (comment) (rename the files to plural and the docregion to singular), squash the commits into one and update the commit message to something along the lines of dd9793f?

sonukapoor · 2019-12-16T15:10:48Z

@gkalpak I believe this resolves everything. LMK if anything is missing.

mary-poppins · 2019-12-16T15:17:44Z

You can preview 5763d55 at https://pr34327-5763d55.ngbuilds.io/.

gkalpak

Great work, @sonukapoor! Thx 💯

…into a proper mini-app Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes angular#31024

mary-poppins · 2019-12-16T17:25:55Z

You can preview 692bf9e at https://pr34327-692bf9e.ngbuilds.io/.

sonukapoor · 2020-01-07T01:02:46Z

@IgorMinar Can you please review this?

Splaktar

LGTM

IgorMinar

Looks great! Thank you

gkalpak · 2020-01-19T19:51:47Z

@caretaker: Global approval for the docs-only changes.

…into a proper mini-app (#34327) Previously, the examples in the `comparing-observables` guide were hard-coded. This made it impossible to test them and verify they are correct. This commit fixes this by converting them into a proper mini-app. In a subsequent commit, tests will be added to verify that the source code works as expected (and guard against regressions). Fixes #31024 PR Close #34327

angular-automatic-lock-bot · 2020-02-23T16:09:22Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

sonukapoor requested a review from IgorMinar as a code owner December 10, 2019 14:50

sonukapoor requested a review from a team December 10, 2019 14:50

googlebot added the cla: yes label Dec 10, 2019

AndrewKushnir added the comp: docs-infra label Dec 11, 2019

ngbot Bot added this to the needsTriage milestone Dec 11, 2019

gkalpak added aio: preview area: build & ci Related the build and CI infrastructure of the project action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Dec 12, 2019

gkalpak suggested changes Dec 12, 2019

View reviewed changes

gkalpak added state: WIP and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 12, 2019

sonukapoor requested review from a team and gkalpak December 12, 2019 21:06

gkalpak suggested changes Dec 13, 2019

View reviewed changes

sonukapoor requested a review from gkalpak December 13, 2019 15:29

sonukapoor mentioned this pull request Dec 13, 2019

docs: Add missing tests for comparing observables #34398

Closed

gkalpak suggested changes Dec 15, 2019

View reviewed changes

sonukapoor force-pushed the converts-hard-coded-examples-to-proper-examples branch from dd1e075 to 5763d55 Compare December 16, 2019 15:08

sonukapoor requested a review from gkalpak December 16, 2019 15:09

sonukapoor force-pushed the converts-hard-coded-examples-to-proper-examples branch from 5763d55 to b7ebe78 Compare December 16, 2019 16:22

gkalpak changed the title ~~fix(docs-infra): convert hard-coded rxjs examples into proper mini-te…~~ fix(docs-infra): convert hard-coded comparing-observables examples into a proper mini-app Dec 16, 2019

sonukapoor force-pushed the converts-hard-coded-examples-to-proper-examples branch from b7ebe78 to 70e85d1 Compare December 16, 2019 16:35

gkalpak added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Dec 16, 2019

gkalpak approved these changes Dec 16, 2019

View reviewed changes

sonukapoor force-pushed the converts-hard-coded-examples-to-proper-examples branch from 70e85d1 to 24a7a71 Compare December 16, 2019 16:45

sonukapoor force-pushed the converts-hard-coded-examples-to-proper-examples branch from 24a7a71 to 692bf9e Compare December 16, 2019 17:16

gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 16, 2019

gkalpak assigned IgorMinar Dec 16, 2019

kara added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 16, 2019

gkalpak mentioned this pull request Dec 23, 2019

test(docs-infra): add missing tests for observables and promises #34537

Closed

4 of 14 tasks

atscott removed the action: merge The PR is ready for merge by the caretaker label Jan 10, 2020

Splaktar approved these changes Jan 17, 2020

View reviewed changes

IgorMinar approved these changes Jan 19, 2020

View reviewed changes

IgorMinar added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jan 19, 2020

gkalpak added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jan 19, 2020

matsko closed this in def4127 Jan 21, 2020

sonukapoor deleted the converts-hard-coded-examples-to-proper-examples branch January 23, 2020 22:29

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Feb 23, 2020

Conversation

sonukapoor commented Dec 10, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

mary-poppins commented Dec 12, 2019

Uh oh!

gkalpak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Dec 12, 2019

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mary-poppins commented Dec 13, 2019

Uh oh!

gkalpak left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonukapoor commented Dec 16, 2019

Uh oh!

mary-poppins commented Dec 16, 2019

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

mary-poppins commented Dec 16, 2019

Uh oh!

sonukapoor commented Jan 7, 2020

Uh oh!

Splaktar left a comment

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Jan 19, 2020

Uh oh!

angular-automatic-lock-bot Bot commented Feb 23, 2020

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gkalpak left a comment •

edited

Loading

gkalpak left a comment •

edited

Loading