Repository navigation
test(docs-infra): add unit tests for rxjs examples #34190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
sonukapoor
wants to merge
2
commits into
angular:master
from
sonukapoor:unit-tests-for-stand-alone-code
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| import { docRegionFromEvent, docRegionSubscriber } from './creating'; | ||
|
|
||
| describe('observables', () => { | ||
| it('should create an observable using the constructor', () => { | ||
| const console = {log: jasmine.createSpy('log')}; | ||
| docRegionSubscriber(console); | ||
| expect(console.log).toHaveBeenCalledTimes(4); | ||
| expect(console.log.calls.allArgs()).toEqual([ | ||
| [1], | ||
| [2], | ||
| [3], | ||
| ['Finished sequence'], | ||
| ]); | ||
| }); | ||
|
|
||
| it('should listen to input changes', () => { | ||
| let triggerInputChange; | ||
| const input = { | ||
| value: 'Test', | ||
| addEventListener: jasmine | ||
| .createSpy('addEvent') | ||
| .and.callFake((eventName: string, cb: (e) => void) => { | ||
| if (eventName === 'keydown') { | ||
| triggerInputChange = cb; | ||
| } | ||
| }), | ||
| removeEventListener: jasmine.createSpy('removeEventListener'), | ||
| }; | ||
|
|
||
| const document = { getElementById: () => input }; | ||
| docRegionFromEvent(document); | ||
| triggerInputChange({keyCode: 65}); | ||
| expect(input.value).toBe('Test'); | ||
|
|
||
| triggerInputChange({keyCode: 27}); | ||
| expect(input.value).toBe(''); | ||
| }); | ||
|
|
||
| it('should call removeEventListener when unsubscribing', (doneFn: DoneFn) => { | ||
| const input = { | ||
| addEventListener: jasmine.createSpy('addEvent'), | ||
| removeEventListener: jasmine | ||
| .createSpy('removeEvent') | ||
| .and.callFake((eventName: string, cb: (e) => void) => { | ||
| if (eventName === 'keydown') { | ||
| doneFn(); | ||
| } | ||
| }) | ||
| }; | ||
|
|
||
| const document = { getElementById: () => input }; | ||
| const subscription = docRegionFromEvent(document); | ||
| subscription.unsubscribe(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| import { docRegionDelaySequence, docRegionMulticastSequence } from './multicasting'; | ||
|
|
||
| describe('multicasting', () => { | ||
| let console; | ||
| beforeEach(() => { | ||
| jasmine.clock().install(); | ||
| console = {log: jasmine.createSpy('log')}; | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| jasmine.clock().uninstall(); | ||
| }); | ||
|
gkalpak marked this conversation as resolved.
Resolved
|
||
|
|
||
| it('should create an observable and emit in sequence', () => { | ||
| docRegionDelaySequence(console); | ||
| jasmine.clock().tick(10000); | ||
| expect(console.log).toHaveBeenCalledTimes(12); | ||
| expect(console.log.calls.allArgs()).toEqual([ | ||
| [1], | ||
| ['1st subscribe: 1'], | ||
| ['2nd subscribe: 1'], | ||
| [2], | ||
| ['1st subscribe: 2'], | ||
| ['2nd subscribe: 2'], | ||
| [3], | ||
| ['Finished sequence'], | ||
| ['1st subscribe: 3'], | ||
| ['1st sequence finished.'], | ||
| ['2nd subscribe: 3'], | ||
| ['2nd sequence finished.'] | ||
| ]); | ||
| }); | ||
|
|
||
| it('should create an observable and multicast the emissions', () => { | ||
| docRegionMulticastSequence(console); | ||
| jasmine.clock().tick(10000); | ||
| expect(console.log).toHaveBeenCalledTimes(7); | ||
| expect(console.log.calls.allArgs()).toEqual([ | ||
| ['1st subscribe: 1'], | ||
| ['1st subscribe: 2'], | ||
| ['2nd subscribe: 2'], | ||
| ['1st subscribe: 3'], | ||
| ['2nd subscribe: 3'], | ||
| ['1st sequence finished.'], | ||
| ['2nd sequence finished.'] | ||
| ]); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.