Repository navigation
fix(ivy): prevent unknown element check for AOT-compiled components - #34024
Closed
AndrewKushnir wants to merge 2 commits into
Closed
AndrewKushnir wants to merge 2 commits into
AndrewKushnir wants to merge 2 commits into
Conversation
Contributor
Author
|
@petebacondarwin @crisbeto could you please have a look at this draft PR (we discussed these changes offline) when you get a chance? Thank you. |
crisbeto
reviewed
Nov 25, 2019
petebacondarwin
approved these changes
Nov 25, 2019
AndrewKushnir
added
target: patch
AndrewKushnir
marked this pull request as ready for review
November 25, 2019 18:35
AndrewKushnir
added
the
action: review
Contributor
Author
AndrewKushnir
added
the
action: presubmit
kara
self-requested a review
November 25, 2019 23:21
IgorMinar
approved these changes
Nov 26, 2019
Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that `schemas` information is not present on Component and NgModule defs after AOT compilation, the second check (at runtime) may fail, even though the same check was successful at compile time. This commit updates the code to avoid the second check for AOT-compiled components by checking whether `schemas` information is present in a logic that executes the unknown element check.
AndrewKushnir
force-pushed
the
FW-1736_unknown_element_check_jit
branch
from
November 27, 2019 01:31
e956bf9 to
a7fdeae
Compare
AndrewKushnir
removed
the
action: presubmit
kara
removed their request for review
November 27, 2019 20:39
mhevery
added
action: merge
mhevery
pushed a commit
that referenced
this pull request
Nov 27, 2019
…34024) Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that `schemas` information is not present on Component and NgModule defs after AOT compilation, the second check (at runtime) may fail, even though the same check was successful at compile time. This commit updates the code to avoid the second check for AOT-compiled components by checking whether `schemas` information is present in a logic that executes the unknown element check. PR Close #34024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the unknown element can happen twice for AOT-compiled components: once during compilation and once again at runtime. Due to the fact that
schemasinformation is not present on Component and NgModule defs after AOT compilation, the second check (at runtime) may fail, even though the same check was successful at compile time. This commit updates the code to avoid the second check for AOT-compiled components by checking whetherschemasinformation is present in a logic that executes the unknown element check.This PR resolves FW-1736.
Resolves #33976.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?