Repository navigation
fix(ngcc): report errors from analyze and resolve processing - #33964
Closed
petebacondarwin wants to merge 2 commits into
Closed
petebacondarwin wants to merge 2 commits into
petebacondarwin wants to merge 2 commits into
Conversation
Previously, these errors were being swallowed, which made it hard to debug problems with packages. See angular#33685 (comment)
petebacondarwin
added
type: bug/fix
action: review
gkalpak
approved these changes
Nov 21, 2019
gkalpak
added
action: cleanup
gkalpak
reviewed
Nov 21, 2019
Member
|
BTW, the integration size check failure is unrelated (but the linting one needs fixing). |
petebacondarwin
added
action: merge
alxhub
pushed a commit
that referenced
this pull request
Nov 21, 2019
) Previously, these errors were being swallowed, which made it hard to debug problems with packages. See #33685 (comment) PR Close #33964
JoostK
added a commit
to JoostK/ngcc-validation
that referenced
this pull request
Nov 22, 2019
In angular/angular#33964 an issue was fixed where metadata resolution diagnostics were never reported. This commit adds projects that are now failing, as reporting the diagnostics prevents the libraries from building correctly. Note, however, that these problems are not really new; these packages can not have worked correctly before.
mgechev
pushed a commit
to angular/ngcc-validation
that referenced
this pull request
Nov 23, 2019
In angular/angular#33964 an issue was fixed where metadata resolution diagnostics were never reported. This commit adds projects that are now failing, as reporting the diagnostics prevents the libraries from building correctly. Note, however, that these problems are not really new; these packages can not have worked correctly before.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, these errors were being swallowed, which made it
hard to debug problems with packages.
See #33685 (comment)