Skip to content

feat(docs-infra): simplify image styles and remove figure references#33748

Closed
sjtrimble wants to merge 2 commits into
angular:masterfrom
sjtrimble:figure-restructure
Closed

feat(docs-infra): simplify image styles and remove figure references#33748
sjtrimble wants to merge 2 commits into
angular:masterfrom
sjtrimble:figure-restructure

Conversation

@sjtrimble

@sjtrimble sjtrimble commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

Reference #33259
Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Removes figure elements not necessary

Does this PR introduce a breaking change?

  • Yes
  • No

@sjtrimble sjtrimble added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra labels Nov 11, 2019
@sjtrimble sjtrimble requested review from a team and gkalpak November 11, 2019 22:50
@sjtrimble sjtrimble self-assigned this Nov 11, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Nov 11, 2019
@mary-poppins

mary-poppins commented Nov 11, 2019

Copy link
Copy Markdown

You can preview 7b1d741 at https://pr33748-7b1d741.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 13, 2019
gkalpak
gkalpak approved these changes Nov 13, 2019
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Comment thread aio/content/guide/docs-style-guide.md Outdated
@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: merge The PR is ready for merge by the caretaker labels Nov 13, 2019
@ngbot ngbot Bot added the action: merge The PR is ready for merge by the caretaker label Nov 13, 2019
@googlebot

googlebot commented Nov 13, 2019

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@gkalpak gkalpak removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Nov 13, 2019
@gkalpak

gkalpak commented Nov 13, 2019

Copy link
Copy Markdown
Member

@googlebot I consent.

@googlebot

googlebot commented Nov 13, 2019

Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@gkalpak

gkalpak commented Nov 13, 2019

Copy link
Copy Markdown
Member

merge-assistance: Global approval for this docs-only change.

@mary-poppins

mary-poppins commented Nov 13, 2019

Copy link
Copy Markdown

You can preview 42e98da at https://pr33748-42e98da.ngbuilds.io/.

sjtrimble and others added 2 commits November 13, 2019 16:44
@sjtrimble @gkalpak
feat(docs-infra): simplify image styles and remove figure references
598f75a 
Reference angular#33259
Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate
@gkalpak
fixup! feat(docs-infra): simplify image styles and remove figure refe…
7f39cf7 
…rences
@mary-poppins

mary-poppins commented Nov 13, 2019

Copy link
Copy Markdown

You can preview 7f39cf7 at https://pr33748-7f39cf7.ngbuilds.io/.

@kara

kara commented Nov 13, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

@gkalpak Are you giving this global approval for docs changes? I didn't see a comment to explain the "merge assistance" label

I see your comment now. Not sure how I missed it!

@kara kara added action: review The PR is still awaiting reviews from at least one requested reviewer and removed merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 13, 2019
@kara kara added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 13, 2019
@alxhub alxhub closed this in fe4447d Nov 14, 2019
alxhub pushed a commit that referenced this pull request Nov 14, 2019
@sjtrimble @alxhub
feat(docs-infra): simplify image styles and remove figure references (#…
1860a9e 
…33748)

Reference #33259
Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate

PR Close #33748
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Dec 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gkalpak gkalpak gkalpak approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@sjtrimble @mary-poppins @googlebot @gkalpak @kara