Repository navigation
build: typescript 3.7 support #33717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0265477
build: typescript 3.7 support
andrius-pra 7d95447
test: add yarn.lock to typings_test_ts37
filipesilva a0bf710
build: update tsickle to 0.38.0
filipesilva c600886
test(docs-infra): compile only app for examples with no e2e
filipesilva 8c127de
build(docs-infra): use typescript 3.7
filipesilva 000581b
test: use ts 3.7 on material unit tests
filipesilva bf9e692
test: fix path to dist zone.js
filipesilva e437e0a
test: save material ts override as a devdep
filipesilva 00c5d52
test: also install tsickle 0.38 on material
filipesilva 05ed101
ci: update material-unit-tests commit
devversion 3bbdc8e
ci: overwrite angular/components yarn typescript resolution
devversion 323e12c
ci: update material-unit-tests commit
andrius-pra 6b5a63d
fixup! build: typescript 3.7 support
filipesilva e23e0cc
test: update typings test to use ts 3.7.4 instead of 3.7.3
IgorMinar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google Inc. All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
|
|
||
|
|
||
|
|
||
| import * as animations from '@angular/animations'; | ||
| import * as animationsBrowser from '@angular/animations/browser'; | ||
| import * as animationsBrowserTesting from '@angular/animations/browser/testing'; | ||
| import * as common from '@angular/common'; | ||
| import * as commonHttp from '@angular/common/http'; | ||
| import * as commonTesting from '@angular/common/testing'; | ||
| import * as commonHttpTesting from '@angular/common/testing'; | ||
| import * as compiler from '@angular/compiler'; | ||
| import * as compilerTesting from '@angular/compiler/testing'; | ||
| import * as core from '@angular/core'; | ||
| import * as coreTesting from '@angular/core/testing'; | ||
| import * as elements from '@angular/elements'; | ||
| import * as forms from '@angular/forms'; | ||
| // Current plan for Angular 8 is to stop building the @angular/http package | ||
| // import * as http from '@angular/http'; | ||
| // import * as httpTesting from '@angular/http/testing'; | ||
| import * as platformBrowser from '@angular/platform-browser'; | ||
| import * as platformBrowserDynamic from '@angular/platform-browser-dynamic'; | ||
| import * as platformBrowserDynamicTesting from '@angular/platform-browser-dynamic/testing'; | ||
| import * as platformBrowserAnimations from '@angular/platform-browser/animations'; | ||
| import * as platformBrowserTesting from '@angular/platform-browser/testing'; | ||
| import * as platformServer from '@angular/platform-server'; | ||
| import * as platformServerTesting from '@angular/platform-server/testing'; | ||
| import * as platformWebworker from '@angular/platform-webworker'; | ||
| import * as platformWebworkerDynamic from '@angular/platform-webworker-dynamic'; | ||
| import * as router from '@angular/router'; | ||
| import * as routerTesting from '@angular/router/testing'; | ||
| import * as routerUpgrade from '@angular/router/upgrade'; | ||
| import * as serviceWorker from '@angular/service-worker'; | ||
| import * as upgrade from '@angular/upgrade'; | ||
| import * as upgradeStatic from '@angular/upgrade/static'; | ||
| import * as upgradeTesting from '@angular/upgrade/static/testing'; | ||
|
|
||
| export default { | ||
| animations, | ||
| animationsBrowser, | ||
| animationsBrowserTesting, | ||
| common, | ||
| commonTesting, | ||
| commonHttp, | ||
| commonHttpTesting, | ||
| compiler, | ||
| compilerTesting, | ||
| core, | ||
| coreTesting, | ||
| elements, | ||
| forms, | ||
| // See above | ||
| // http, | ||
| // httpTesting, | ||
| platformBrowser, | ||
| platformBrowserTesting, | ||
| platformBrowserDynamic, | ||
| platformBrowserDynamicTesting, | ||
| platformBrowserAnimations, | ||
| platformServer, | ||
| platformServerTesting, | ||
| platformWebworker, | ||
| platformWebworkerDynamic, | ||
| router, | ||
| routerTesting, | ||
| routerUpgrade, | ||
| serviceWorker, | ||
| upgrade, | ||
| upgradeStatic, | ||
| upgradeTesting, | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "name": "angular-integration", | ||
| "description": "Assert that users with TypeScript 3.7 can type-check an Angular application", | ||
| "version": "0.0.0", | ||
| "license": "MIT", | ||
| "dependencies": { | ||
| "@angular/animations": "file:../../dist/packages-dist/animations", | ||
| "@angular/common": "file:../../dist/packages-dist/common", | ||
| "@angular/compiler": "file:../../dist/packages-dist/compiler", | ||
| "@angular/compiler-cli": "file:../../dist/packages-dist/compiler-cli", | ||
| "@angular/core": "file:../../dist/packages-dist/core", | ||
| "@angular/elements": "file:../../dist/packages-dist/elements", | ||
| "@angular/forms": "file:../../dist/packages-dist/forms", | ||
| "@angular/platform-browser": "file:../../dist/packages-dist/platform-browser", | ||
| "@angular/platform-browser-dynamic": "file:../../dist/packages-dist/platform-browser-dynamic", | ||
| "@angular/platform-server": "file:../../dist/packages-dist/platform-server", | ||
| "@angular/platform-webworker": "file:../../dist/packages-dist/platform-webworker", | ||
| "@angular/platform-webworker-dynamic": "file:../../dist/packages-dist/platform-webworker-dynamic", | ||
| "@angular/router": "file:../../dist/packages-dist/router", | ||
| "@angular/service-worker": "file:../../dist/packages-dist/service-worker", | ||
| "@angular/upgrade": "file:../../dist/packages-dist/upgrade", | ||
| "@types/jasmine": "2.5.41", | ||
| "rxjs": "file:../../node_modules/rxjs", | ||
| "typescript": "3.7.4", | ||
| "zone.js": "file:../../dist/zone.js-dist/zone.js" | ||
| }, | ||
| "scripts": { | ||
| "test": "tsc" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "emitDecoratorMetadata": true, | ||
| "experimentalDecorators": true, | ||
| "module": "commonjs", | ||
| "moduleResolution": "node", | ||
| "outDir": "../../dist/typings_test_ts37/", | ||
| "rootDir": ".", | ||
| "target": "es5", | ||
| "lib": [ | ||
| "es5", | ||
| "dom", | ||
| "es2015.collection", | ||
| "es2015.iterable", | ||
| "es2015.promise" | ||
| ], | ||
| "types": [], | ||
| "strictNullChecks": true | ||
| }, | ||
| "files": [ | ||
| "include-all.ts", | ||
| "node_modules/@types/jasmine/index.d.ts" | ||
| ] | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little surprised this works (e.g. I would expect ngcc from the currently installed @angular/compiler-cli@9.0.0-rc.3 to fail), but if CI is happy, so am I 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted this change.