feat(docs-infra): implement figure styles by sjtrimble · Pull Request #33259 · angular/angular

sjtrimble · 2019-10-18T23:24:52Z

PR#28396 originally addressed an update via issue #23983 to make images more visible with a white background (implementation of gray "lightbox").

This PR implements those styles defined in PR#28396.

PR Checklist

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Images are often lost since the background change to white.

Issue Number: #23983 | and PR #28396

What is the new behavior?

Add a shadowed gray 'lightbox' to better define images throughout the documentation.

Does this PR introduce a breaking change?

Yes
No

PR#28396 originally addressed an update via issue angular#23983 to make images more visible with a white background (implementation of gray "lightbox"). This PR implements those styles defined in PR#28396.

mary-poppins · 2019-10-18T23:31:33Z

You can preview 187a492 at https://pr33259-187a492.ngbuilds.io/.

gkalpak

Are there occurrences of figure > img, without .lightbox (or a .card)?
If so, how does one decide when to use .lightbox and .card and when not?

sjtrimble · 2019-10-21T20:31:32Z

@gkalpak eek :/ It looks like one my fixup commits never made it on there?

I "THINK" I took care of everything.

The extra lines were there originally and sometimes my editor made it look like I wasn't supposed to indent properly so I thought maybe it would break the markdown if I did...

I was going to update the style guide to reflect when to use the lightbox and card etc.

mary-poppins · 2019-10-21T20:35:48Z

You can preview 65e6295 at https://pr33259-65e6295.ngbuilds.io/.

gkalpak · 2019-10-22T09:02:11Z

Are there occurrences of figure > img, without .lightbox (or a .card)?
If so, how does one decide when to use .lightbox and .card and when not?

I was going to update the style guide to reflect when to use the lightbox and card etc.

Were or are? 😕 😛
I definitely agree this should be in the guide 💯

My concern is that we are complicating the conventions one has to follow, which will inevitably result in them not being consistently followed 😟
I would love if we could simplify things. For example, if .card should always be used with .lightbox, then we might be able to get rid of the nested .card and style the .lightbox (or the contained imaged) instead. Or if most fixures will use .lightbox, we could make it the default and have another class to "opt-out" of the .lightbox styling.

sjtrimble · 2019-10-22T20:40:51Z

@gkalpak Is there anything missing for this PR?

mary-poppins · 2019-10-22T20:48:33Z

You can preview 81d5340 at https://pr33259-81d5340.ngbuilds.io/.

googlebot · 2019-10-23T09:38:56Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

gkalpak · 2019-10-23T09:41:08Z

@sjtrimble, I pushed a fixup commit with some indentation fixes. If you are happy with that, feel free to mark the PR for merging (remove the PR action cleanup label and add the PR action: merge and PR action: merge-assistance labels).

gkalpak · 2019-10-23T09:42:42Z

@googlebot I consent.

googlebot · 2019-10-23T09:42:48Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

gkalpak · 2019-10-23T09:42:54Z

merge-assistance: Global approval for this docs(-infra)-only change.

mary-poppins · 2019-10-23T09:45:45Z

You can preview 771a723 at https://pr33259-771a723.ngbuilds.io/.

sjtrimble · 2019-10-23T19:51:44Z

Thanks @gkalpak , u da best :P

PR#28396 originally addressed an update via issue #23983 to make images more visible with a white background (implementation of gray "lightbox"). This PR implements those styles defined in PR#28396. PR Close #33259

Reference angular#33259 Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate

…33748) Reference #33259 Removes figures elements as AIO is not typically using captions or image groups where figures would be necessary or appropriate PR Close #33748

angular-automatic-lock-bot · 2019-11-23T16:10:08Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

feat(docs-infra): implement figure styles

187a492

PR#28396 originally addressed an update via issue angular#23983 to make images more visible with a white background (implementation of gray "lightbox"). This PR implements those styles defined in PR#28396.

sjtrimble added action: review The PR is still awaiting reviews from at least one requested reviewer comp: docs-infra labels Oct 18, 2019

sjtrimble requested review from a team and gkalpak October 18, 2019 23:24

sjtrimble self-assigned this Oct 18, 2019

ngbot Bot modified the milestone: needsTriage Oct 18, 2019

googlebot added the cla: yes label Oct 18, 2019

gkalpak suggested changes Oct 19, 2019

View reviewed changes

sjtrimble added 2 commits October 21, 2019 13:25

fixup! feat(docs-infra): implement figure styles

343bfe1

fixup! feat(docs-infra): implement figure styles

65e6295

gkalpak reviewed Oct 22, 2019

View reviewed changes

gkalpak approved these changes Oct 23, 2019

View reviewed changes

fixup! feat(docs-infra): implement figure styles

771a723

googlebot added cla: no and removed cla: yes labels Oct 23, 2019

googlebot added cla: yes and removed cla: no labels Oct 23, 2019

sjtrimble added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 23, 2019

AndrewKushnir closed this in ba29e4d Oct 23, 2019

sjtrimble mentioned this pull request Nov 11, 2019

feat(docs-infra): simplify image styles and remove figure references #33748

Closed

14 tasks

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 23, 2019

Conversation

sjtrimble commented Oct 18, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Uh oh!

mary-poppins commented Oct 18, 2019

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sjtrimble commented Oct 21, 2019

Uh oh!

mary-poppins commented Oct 21, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gkalpak commented Oct 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sjtrimble commented Oct 22, 2019

Uh oh!

mary-poppins commented Oct 22, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

googlebot commented Oct 23, 2019

Uh oh!

gkalpak commented Oct 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gkalpak commented Oct 23, 2019

Uh oh!

googlebot commented Oct 23, 2019

Uh oh!

gkalpak commented Oct 23, 2019

Uh oh!

mary-poppins commented Oct 23, 2019

Uh oh!

sjtrimble commented Oct 23, 2019

Uh oh!

angular-automatic-lock-bot Bot commented Nov 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gkalpak commented Oct 22, 2019 •

edited

Loading

gkalpak commented Oct 23, 2019 •

edited

Loading