Update CLI integration test project structure by filipesilva · Pull Request #33175 · angular/angular

filipesilva · 2019-10-15T15:17:13Z

Blocked on #32957, needs to go in after so that the size increases due to different default template are validated separately.

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

alan-agius4 · 2019-10-16T14:18:50Z

Is this change intended?

Nope, just an oversight, will fix.

IgorMinar

the rest looks good, thanks!

IgorMinar · 2019-10-18T18:18:12Z

is this intentionally disabled?

It was, yes. While working in these integration PRs I disable the rest of CI to make it faster and less expensive.

IgorMinar · 2019-10-18T18:19:06Z

we don't need to track es5 here. we care primarily about es2015 sizes.

IgorMinar · 2019-10-18T18:20:21Z

in the ts 3.6 update PR we fixed the schematic to make it compatible with recent cli version, so you no longer should need to downgrade. undo plz

That was part of the old rebase and is now gone.

IgorMinar · 2019-10-18T18:23:35Z

Suggested change

describe('workspace-project App', () => {

describe('cli-hello-world-ivy-compat App', () => {

Fixed this one and three others that were also the same.

IgorMinar · 2019-10-21T16:02:53Z

please remove the es5 sizes, we don't want to break the build when they change.

…#33175) PR Close #33175

…33175) PR Close #33175

#33175) PR Close #33175

PR Close #33175

angular-automatic-lock-bot · 2019-11-21T16:10:32Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

filipesilva added the state: blocked label Oct 15, 2019

googlebot added the cla: yes label Oct 15, 2019

mhevery added the area: core Issues related to the framework runtime label Oct 15, 2019

ngbot Bot added this to the needsTriage milestone Oct 15, 2019

alan-agius4 reviewed Oct 16, 2019

View reviewed changes

This was referenced Oct 17, 2019

feat: typescript 3.6 support #32946

Closed

Update Angular CLI packages, and add CLI lazy chunks and ngDevMode integration test #32957

Closed

filipesilva marked this pull request as ready for review October 21, 2019 15:42

filipesilva requested a review from a team October 21, 2019 15:42

filipesilva added action: review The PR is still awaiting reviews from at least one requested reviewer target: major This PR is targeted for the next major release and removed state: blocked labels Oct 21, 2019

mhevery approved these changes Oct 21, 2019

View reviewed changes

mhevery removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 21, 2019

IgorMinar approved these changes Oct 21, 2019

View reviewed changes

IgorMinar added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 21, 2019

filipesilva added 6 commits October 21, 2019 18:08

test: update integration/cli-hello-world project structure

5b4ce28

test: update integration/cli-hello-world-ivy-compat project structure

b0e05e5

test: update integration/cli-hello-world-ivy-i18n project structure

c683c0a

test: update integration/cli-hello-world-ivy-minimal project structure

fbb9ea9

test: disable es5 size tracking in integration tests

7ce8592

test: fix typo in cli e2e descriptions

3dbdcb0

filipesilva added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 21, 2019

matsko closed this in fbf6ec8 Oct 21, 2019

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: update integration/cli-hello-world-ivy-compat project structure (…

3f273f8

…#33175) PR Close #33175

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: update integration/cli-hello-world-ivy-i18n project structure (#…

3ae72dc

…33175) PR Close #33175

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: update integration/cli-hello-world-ivy-minimal project structure (

8e2e1f8

#33175) PR Close #33175

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: disable es5 size tracking in integration tests (#33175)

ff36a8d

PR Close #33175

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: fix typo in cli e2e descriptions (#33175)

9de4b1c

PR Close #33175

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 21, 2019

	describe('workspace-project App', () => {
	describe('cli-hello-world-ivy-compat App', () => {

Conversation

filipesilva commented Oct 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IgorMinar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Nov 21, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

filipesilva commented Oct 15, 2019 •

edited

Loading