Update Angular CLI packages, and add CLI lazy chunks and ngDevMode integration test by filipesilva · Pull Request #32957 · angular/angular

filipesilva · 2019-10-02T12:10:14Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

filipesilva · 2019-10-03T13:21:58Z

Blocked by angular/angular-cli#15749, this seems to be the cause of the size regressions.

filipesilva · 2019-10-17T13:14:36Z

Sizes for this test changed because they weren't actually being tracked. When I changed run_tests.sh to run over all cli-hello-world* tests, they started being tracked.

gkalpak

Are the package-lock.json files checked in by accident in cli-hello-world-lazy and cli-hello-world-lazy-rollup?

gkalpak

Other than #32957 (review), it lgtm 🎉

kara

LGTM, aside from a few small things

kara · 2019-10-17T22:24:24Z

Maybe slightly more info in case contributors don't have context

Suggested change

throw new Error(`Found '${ngDevModeVariable}' referenced in ${filesWithNgDevMode}`);

throw new Error(`Found '${ngDevModeVariable}' referenced in ${filesWithNgDevMode. These references should be tree-shaken away!}`);

kara · 2019-10-17T22:36:42Z

Same here as the other error message

kara · 2019-10-17T22:39:42Z

We are installing devkit next.11 in the size tests, but CLI next.9. Why don't they match?

…ntalRollupPass

josephperrott

LGTM

…32957) PR Close #32957

…ntalRollupPass (#32957) PR Close #32957

angular-automatic-lock-bot · 2019-11-21T16:10:20Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

googlebot added the cla: yes label Oct 2, 2019

filipesilva changed the title ~~Update cli and ngdevmode~~ Update Angular CLI packages, and add CLI ngDevMode integration test Oct 2, 2019

atscott added the area: build & ci Related the build and CI infrastructure of the project label Oct 2, 2019

ngbot Bot added this to the needsTriage milestone Oct 2, 2019

filipesilva mentioned this pull request Oct 3, 2019

feat(@angular-devkit/build-optimizer): don't use getImportTslibTransformer angular/angular-cli#15749

Merged

filipesilva added the target: major This PR is targeted for the next major release label Oct 15, 2019

filipesilva changed the title ~~Update Angular CLI packages, and add CLI ngDevMode integration test~~ Update Angular CLI packages, and add CLI lazy chunks and ngDevMode integration test Oct 15, 2019

filipesilva commented Oct 15, 2019

View reviewed changes

Comment thread integration/bazel-schematics/package.json Resolved

filipesilva requested review from gkalpak and kara October 15, 2019 15:13

filipesilva marked this pull request as ready for review October 15, 2019 15:14

filipesilva requested review from a team and josephperrott October 15, 2019 15:14

filipesilva mentioned this pull request Oct 15, 2019

Update CLI integration test project structure #33175

Closed

3 of 14 tasks

filipesilva removed the request for review from josephperrott October 17, 2019 10:55

filipesilva commented Oct 17, 2019

View reviewed changes

filipesilva added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 17, 2019

gkalpak reviewed Oct 17, 2019

View reviewed changes

filipesilva mentioned this pull request Oct 17, 2019

feat: typescript 3.6 support #32946

Closed

2 of 3 tasks

gkalpak approved these changes Oct 17, 2019

View reviewed changes

kara approved these changes Oct 17, 2019

View reviewed changes

kara added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 17, 2019

kara assigned filipesilva Oct 17, 2019

filipesilva removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Oct 18, 2019

filipesilva assigned josephperrott and unassigned filipesilva Oct 18, 2019

filipesilva requested a review from josephperrott October 18, 2019 10:26

test: update Angular CLI deps for integration tests

935c5c8

filipesilva added 2 commits October 18, 2019 19:09

test: add integration test for lazy chunks and ngDevMode in cli apps

37f401b

test: add integration test for lazy chunks in cli apps using experime…

3396ba5

…ntalRollupPass

josephperrott approved these changes Oct 21, 2019

View reviewed changes

josephperrott removed the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 21, 2019

filipesilva added the action: merge The PR is ready for merge by the caretaker label Oct 21, 2019

matsko closed this in abd2a58 Oct 21, 2019

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: add integration test for lazy chunks and ngDevMode in cli apps (#…

609d255

…32957) PR Close #32957

matsko pushed a commit that referenced this pull request Oct 21, 2019

test: add integration test for lazy chunks in cli apps using experime…

6471a26

…ntalRollupPass (#32957) PR Close #32957

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 21, 2019

	throw new Error(`Found '${ngDevModeVariable}' referenced in ${filesWithNgDevMode}`);
	throw new Error(`Found '${ngDevModeVariable}' referenced in ${filesWithNgDevMode. These references should be tree-shaken away!}`);

Conversation

filipesilva commented Oct 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Uh oh!

filipesilva commented Oct 3, 2019

Uh oh!

Uh oh!

filipesilva Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gkalpak left a comment

Choose a reason for hiding this comment

Uh oh!

kara left a comment

Choose a reason for hiding this comment

Uh oh!

kara Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

kara Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

kara Oct 17, 2019

Choose a reason for hiding this comment

Uh oh!

filipesilva Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot Bot commented Nov 21, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

filipesilva commented Oct 2, 2019 •

edited

Loading