Skip to content

build(docs-infra): update in-memory-we-api and karma-jasmine-html-reporter version - #32892

Closed
santoshyadavdev wants to merge 1 commit into
angular:masterfrom
santoshyadavdev:docs--upgrade-in-memory-web-api-version
Closed

build(docs-infra): update in-memory-we-api and karma-jasmine-html-reporter version#32892
santoshyadavdev wants to merge 1 commit into
angular:masterfrom
santoshyadavdev:docs--upgrade-in-memory-web-api-version

Conversation

@santoshyadavdev

@santoshyadavdev santoshyadavdev commented Sep 28, 2019

Copy link
Copy Markdown
Contributor

Fixes #29802

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29802

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@santoshyadavdev
santoshyadavdev requested a review from a team September 28, 2019 11:35
@santoshyadavdev
santoshyadavdev force-pushed the docs--upgrade-in-memory-web-api-version branch from ffb502b to 389e173 Compare September 28, 2019 11:59
@gkalpak gkalpak mentioned this pull request Sep 28, 2019
Closed
@gkalpak gkalpak added aio: preview area: build & ci Related the build and CI infrastructure of the project action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 28, 2019
@mary-poppins

mary-poppins commented Sep 28, 2019

Copy link
Copy Markdown

You can preview 389e173 at https://pr32892-389e173.ngbuilds.io/.

@ngbot ngbot Bot added this to the needsTriage milestone Sep 28, 2019
gkalpak
gkalpak approved these changes Sep 28, 2019
View reviewed changes

@gkalpak gkalpak left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, @santoshyadav198613 👍
Can you please update the commit message to build(docs-infra): ....

Also, (although not directly related to this PR) I noticed that npm test on examples fails due to this issue with karma-jasmine-html-reporter. If you could update to the latest karma-jasmine-html-reporter too (in this PR or another one), that would be rad (but is not blocking this PR) 🔥

@gkalpak gkalpak added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews and removed action: merge The PR is ready for merge by the caretaker labels Sep 28, 2019
@santoshyadavdev

santoshyadavdev commented Sep 29, 2019

Copy link
Copy Markdown
Contributor Author

Thx, @santoshyadav198613
Can you please update the commit message to build(docs-infra): ....

Also, (although not directly related to this PR) I noticed that npm test on examples fails due to this issue with karma-jasmine-html-reporter. If you could update to the latest karma-jasmine-html-reporter too (in this PR or another one), that would be rad (but is not blocking this PR)

Will do that captain :)

@santoshyadavdev
santoshyadavdev force-pushed the docs--upgrade-in-memory-web-api-version branch from 389e173 to 7f642a1 Compare September 29, 2019 15:21
@santoshyadavdev

santoshyadavdev commented Sep 29, 2019

Copy link
Copy Markdown
Contributor Author

Done with the changes.

@mary-poppins

mary-poppins commented Sep 29, 2019

Copy link
Copy Markdown

You can preview 7f642a1 at https://pr32892-7f642a1.ngbuilds.io/.

@gkalpak gkalpak changed the title docs: update in-memory-web-api version build(docs-infra): update in-memory-we-api version Sep 29, 2019
gkalpak
gkalpak suggested changes Sep 29, 2019
View reviewed changes
Comment thread aio/tools/examples/shared/package.json Outdated

@gkalpak gkalpak Sep 29, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for making the change. Can you, please, also update the commit message (to indicate that this is not just about in-memory-web-api (or move this change to a separate PR) and also mention that this fixes taras42/karma-jasmine-html-reporter#31?

@santoshyadavdev santoshyadavdev Sep 30, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the commit message.

@gkalpak gkalpak Sep 30, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, can you please mention that the karma-jasmine-html-reporter update also fixes taras42/karma-jasmine-html-reporter#31 in the commit message?

@santoshyadavdev santoshyadavdev Sep 30, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if its fine I was not able to mention that in the message so added in Fixes

@santoshyadavdev
santoshyadavdev force-pushed the docs--upgrade-in-memory-web-api-version branch from 7f642a1 to 4281b00 Compare September 30, 2019 08:40
@santoshyadavdev santoshyadavdev changed the title build(docs-infra): update in-memory-we-api version build(docs-infra): update in-memory-we-api and karma-jasmine-html-reporter version Sep 30, 2019
@mary-poppins

mary-poppins commented Sep 30, 2019

Copy link
Copy Markdown

You can preview 4281b00 at https://pr32892-4281b00.ngbuilds.io/.

@santoshyadavdev
santoshyadavdev force-pushed the docs--upgrade-in-memory-web-api-version branch from 4281b00 to c28cec2 Compare September 30, 2019 14:13
@mary-poppins

mary-poppins commented Sep 30, 2019

Copy link
Copy Markdown

You can preview c28cec2 at https://pr32892-c28cec2.ngbuilds.io/.

@santoshyadavdev

santoshyadavdev commented Oct 5, 2019

Copy link
Copy Markdown
Contributor Author

Hi @gkalpak ,
Let me know if any changes are needed,

@gkalpak
gkalpak force-pushed the docs--upgrade-in-memory-web-api-version branch from c28cec2 to 9ac5353 Compare October 6, 2019 10:18
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Oct 6, 2019
@gkalpak

gkalpak commented Oct 6, 2019

Copy link
Copy Markdown
Member

Thx for the ping, @santoshyadav198613. I updated the commit message to be more accurate and marked this for merging.

@mary-poppins

mary-poppins commented Oct 6, 2019

Copy link
Copy Markdown

You can preview 9ac5353 at https://pr32892-9ac5353.ngbuilds.io/.

@santoshyadavdev

santoshyadavdev commented Oct 6, 2019

Copy link
Copy Markdown
Contributor Author

Hi @gkalpak ,
Ci failed with error Command "build-with-ivy-ci" not found. Should i sync the branch?

@gkalpak

gkalpak commented Oct 6, 2019

Copy link
Copy Markdown
Member

Yes, please ❤️

@santoshyadavdev
santoshyadavdev force-pushed the docs--upgrade-in-memory-web-api-version branch from 9ac5353 to 6da1718 Compare October 6, 2019 18:26
@mary-poppins

mary-poppins commented Oct 6, 2019

Copy link
Copy Markdown

You can preview 6da1718 at https://pr32892-6da1718.ngbuilds.io/.

@santoshyadavdev
build(docs-infra): update in-memory-we-api and karma-jasmine-html-rep…
dc510ba 
…orter version

The `karma-jasmine-html-reporter` update also includes a fix for
taras42/karma-jasmine-html-reporter#31.

Fixes angular#29802
@santoshyadavdev
santoshyadavdev force-pushed the docs--upgrade-in-memory-web-api-version branch from 6da1718 to dc510ba Compare October 6, 2019 18:32
@mary-poppins

mary-poppins commented Oct 6, 2019

Copy link
Copy Markdown

You can preview dc510ba at https://pr32892-dc510ba.ngbuilds.io/.

@santoshyadavdev

santoshyadavdev commented Oct 6, 2019

Copy link
Copy Markdown
Contributor Author

Yes, please

Hi @gkalpak ,
Done, and CI is green now.

alxhub pushed a commit that referenced this pull request Oct 7, 2019
@santoshyadavdev @alxhub
build(docs-infra): update in-memory-we-api and karma-jasmine-html-rep…
a1d9848 
…orter version (#32892)

The `karma-jasmine-html-reporter` update also includes a fix for
taras42/karma-jasmine-html-reporter#31.

Fixes #29802

PR Close #32892
@alxhub alxhub closed this in 393398e Oct 7, 2019
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Nov 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

Schematics for library project uses angular-in-memory-web-api from brandons repo

4 participants

@santoshyadavdev @mary-poppins @gkalpak @googlebot