Skip to content

docs: fix http example to use correct property - #32288

Closed
kapunahelewong wants to merge 1 commit into
angular:masterfrom
kapunahelewong:http-example-fix
Closed

docs: fix http example to use correct property#32288
kapunahelewong wants to merge 1 commit into
angular:masterfrom
kapunahelewong:http-example-fix

Conversation

@kapunahelewong

@kapunahelewong kapunahelewong commented Aug 23, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #31814

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: Fixes #31814

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Thanks to @ rakeshkohli for bringing this up. 🌟

@kapunahelewong
kapunahelewong requested a review from a team August 23, 2019 12:46
@ngbot ngbot Bot modified the milestone: Backlog Aug 23, 2019
@kapunahelewong kapunahelewong added the target: patch This PR is targeted for the next patch release label Aug 23, 2019
@kapunahelewong
kapunahelewong requested a review from gkalpak August 23, 2019 12:47
@mary-poppins

mary-poppins commented Aug 23, 2019

Copy link
Copy Markdown

You can preview c6b18a6 at https://pr32288-c6b18a6.ngbuilds.io/.

@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Aug 23, 2019
@gkalpak

gkalpak commented Aug 23, 2019

Copy link
Copy Markdown
Member

merge-assistance: Global approval for this docs-only change.

@atscott atscott closed this in 9bb5f05 Aug 23, 2019
atscott pushed a commit that referenced this pull request Aug 23, 2019
@kapunahelewong @atscott
docs: fix http example to use correct property (#32288)
43bac21 
Fixes #31814

PR Close #32288
sabeersulaiman pushed a commit to sabeersulaiman/angular that referenced this pull request Sep 6, 2019
@kapunahelewong @sabeersulaiman
docs: fix http example to use correct property (angular#32288)
800d55e 
Fixes angular#31814

PR Close angular#32288
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 23, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 23, 2019
@kapunahelewong
kapunahelewong deleted the http-example-fix branch June 23, 2020 12:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@Splaktar Splaktar Splaktar approved these changes
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note risk: low target: patch This PR is targeted for the next patch release type: bug/fix

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Issue in Angular example

5 participants

@kapunahelewong @mary-poppins @gkalpak @Splaktar @googlebot