Repository navigation
feat(language-service): Completions for custom-event bindings - #32085
Closed
andrius-pra wants to merge 1 commit into
Closed
andrius-pra wants to merge 1 commit into
andrius-pra wants to merge 1 commit into
Conversation
kara
added
the
area: language-service
andrius-pra
changed the title
kyliau
self-requested a review
September 17, 2019 19:22
Resolves type of $event variable in a custom event binding. So language service can provide completions for $event type members.
andrius-pra
changed the title
Contributor
Author
|
Duplicate of #34570 |
Contributor
|
I didn't see that there was an existing PR for this. If you'd like, feel free to re-open this PR and I will close the other one. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves type of $event variable in a event binding. So language service can provide completions for $event type members.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The method getEventDeclaration() always returns "any" type for the event. So language service can't provide completions for $event variable.
Issue Number: #25545
What is the new behavior?
Determine the type of the event based on the
Observable<T>orEventEmitter<T>types.Does this PR introduce a breaking change?
Other information