Repository navigation
fix(ivy): pass schemas field to nested views - #31913
Closed
AndrewKushnir wants to merge 1 commit into
Closed
AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
Prior to this commit, the `schemas` configuration was applied to top-level view only. That leads to problems when using unknown props with elements inside nested views (for example generated as a result of *ngIf). This commit passes `schemas` information down to nested views to make sure that all the checks are consistent.
AndrewKushnir
added
type: bug/fix
action: review
pkozlowski-opensource
approved these changes
Jul 30, 2019
pkozlowski-opensource
left a comment
pkozlowski-opensource
left a comment
Member
There was a problem hiding this comment.
LGTM (assuming CI is green)
AndrewKushnir
added
the
action: presubmit
Contributor
Author
AndrewKushnir
added
action: merge
sabeersulaiman
pushed a commit
to sabeersulaiman/angular
that referenced
this pull request
Sep 6, 2019
Prior to this commit, the `schemas` configuration was applied to top-level view only. That leads to problems when using unknown props with elements inside nested views (for example generated as a result of *ngIf). This commit passes `schemas` information down to nested views to make sure that all the checks are consistent. PR Close angular#31913
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
schemasconfiguration was applied to top-level view only. That leads to problems when using unknown props with elements inside nested views (for example generated as a result of *ngIf). This commit passesschemasinformation down to nested views to make sure that all the checks are consistent.This PR resolves FW-1492.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?