fix(ivy): include NgModule in incremental compilation if template cha… - #31655

@alxhub points out that this is not a performant solution because it forces the whole compilation scope (i.e the ngModule and all its declared components, directives and pipes) to be recompiled just for a single template change.

Note: the problem is that when the ComponentHandler.resolve() function calls this.scopeRegistry.getScopeForComponent(node); it is getting null because this scopeRegistry has been replaced with a clean copy at the start of this incremental compile.

The better solution is to find a way to pass the CompilationScope for the component whose template has changed from the old IncrementalState to the new IncrementalState. But this is complicated as things are architected currently, since the CompilationScope is stored via various mappings inside a MetadataRegistry/Reader and IncrementalState is also a MetadataRegistry/Reader - and these should not really know about each other or their internals.

Superceded by #31932

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}