Skip to content

fix(bazel): update ng new schema to match the current ng new schema o… - #31234

Closed
alan-agius4 wants to merge 2 commits into
angular:masterfrom
alan-agius4:update-schema-ng-new
Closed

alan-agius4 wants to merge 2 commits into
angular:masterfrom
alan-agius4:update-schema-ng-new

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Jun 24, 2019 •

Copy link
Copy Markdown
Contributor

fix(bazel): update ng new schema to match the current ng new schema of @schematics/angular
The schema used in ng-new bazel, includes several outdated options. With this update we match the current version of @schematics/angular: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/ng-new/schema.json

Relates to #31233

fix(bazel): remove unsupported Css pre-processors from ng new
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

@alan-agius4
alan-agius4 requested a review from a team June 24, 2019 13:29
@alan-agius4 alan-agius4 added area: bazel Issues related to the published `@angular/bazel` build rules target: patch This PR is targeted for the next patch release labels Jun 24, 2019
@ngbot ngbot Bot added this to the needsTriage milestone Jun 24, 2019
…f @schematics/angular

The schema used in ng-new bazel, includes several outdated options. With this update we match the current version of @schematics/angular: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/ng-new/schema.json

Relates to #31233
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209
@alan-agius4
alan-agius4 requested a review from kyliau June 24, 2019 18:13
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Jun 24, 2019
@kara kara closed this in 805fc86 Jun 24, 2019
kara pushed a commit that referenced this pull request Jun 24, 2019
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

PR Close #31234
kara pushed a commit that referenced this pull request Jun 24, 2019
…f @schematics/angular (#31234)

The schema used in ng-new bazel, includes several outdated options. With this update we match the current version of @schematics/angular: https://github.com/angular/angular-cli/blob/master/packages/schematics/angular/ng-new/schema.json

Relates to #31233

PR Close #31234
kara pushed a commit that referenced this pull request Jun 24, 2019
Under Bazel, we don't yet support Stylus and Less, and thus we should not offer the users to generate applications which are known not to work.

Closes #31209

PR Close #31234
@alan-agius4
alan-agius4 deleted the update-schema-ng-new branch June 25, 2019 04:19
@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: bazel Issues related to the published `@angular/bazel` build rules cla: yes target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bazel ng-new schematic doesn't handle less stylesheet format correctly

3 participants