Repository navigation
docs: allow custom package version for example zip file dependencies - #31198
Closed
brandonroberts wants to merge 1 commit into
Closed
brandonroberts wants to merge 1 commit into
brandonroberts wants to merge 1 commit into
Conversation
|
You can preview ff73442 at https://pr31198-ff73442.ngbuilds.io/. |
This change allows you to specify a version that is included in the zip files that users download from the guides. This is a temporary workaround due to the incompatibility of angular-in-memory-web-api with Ivy. The decision is to leave angular-in-memory-web-api as-is until the compatibility issue is resolved. This allows users to use the npm version instead of the custom build we use for Ivy support with the examples. Also adds notes on how to run the E2E tests for the docs examples with Ivy. Fixes angular#28603
brandonroberts
force-pushed
the
docs-in-memory-8-x-ivy
branch
from
June 24, 2019 15:19
ff73442 to
00ff66e
Compare
brandonroberts
added
comp: examples
effort1: hours
target: patch
|
You can preview 00ff66e at https://pr31198-00ff66e.ngbuilds.io/. |
Contributor
Author
|
No longer needed due to #30591. A separate PR will need to be opened to remove the custom build from the examples shared package.json for angular-in-memory-web-api. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows you to specify a version that is included in the zip
files that users download from the guides. This is a temporary workaround
due to the incompatibility of angular-in-memory-web-api with Ivy.
The decision is to leave angular-in-memory-web-api as-is until the
compatibility issue is resolved. This allows users to use the npm
version instead of the custom build we use for Ivy support with the examples.
Also adds notes on how to run the E2E tests for the docs examples with Ivy.
Fixes #28603
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information