Repository navigation
Conversation
ayazhafiz
added
area: compiler
Member
|
Is there a way we can add a test to verify the correct behavior? |
Contributor
Author
Done. Let me know if there's a more ergonomic or appropriate place to put the test. |
alxhub
approved these changes
Jun 20, 2019
ayazhafiz
force-pushed
the
element-parsespan-patch
branch
2 times, most recently
from
June 21, 2019 01:06
fc70a2c to
a38dcf2
Compare
Change the Element constructor in r3_ast to create a new ParseSourceSpan when regenerating it rather than extending an object, which does not contain the overloaded toString().
ayazhafiz
force-pushed
the
element-parsespan-patch
branch
from
June 21, 2019 01:43
a38dcf2 to
3583095
Compare
5 of 14 tasks
Contributor
Author
|
Closing, replaced by #31190 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the Element constructor in r3_ast to create a new ParseSourceSpan when regenerating it rather than extending an object, which does not contain the overloaded toString().
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Parsing a template that has an element with adjacent start and end tags creates an object to represent the element
ParseSourceSpanrather than a new instance of aParseSourceSpan, which does not make the overloadedParseSourceSpan.toStringaccessible.What is the new behavior?
Create a new
ParseSourceSpaninstance.Does this PR introduce a breaking change?
Other information