Repository navigation
Conversation
95e2166 to
1e6d482
Compare
|
I tried to rerun the CI as the errors that showed up seem no longer present on the lastest master. If that doesn't help @H--o-l can you please rebase your PR on top of the most recent master and forcepush to this branch? thanks! |
1e6d482 to
55fe5b8
Compare
|
@IgorMinar CI looks good now, thanks! |
gkalpak
left a comment
There was a problem hiding this comment.
Thx, @H--o-l (both for the PR and for helping get to the bottom of it) 💯
A couple of suggestions (otherwise lgtm):
- Could you, please, make the same change in worker/testing/scope.ts (just in case)?
- Could you mention in the commit message that this was broken in commit b3dda0e?
55fe5b8 to
34d7dc5
Compare
|
@gkalpak I just amend the commit with both improvements. Don't hesitate to tell me if their is anything else. |
There was a problem hiding this comment.
LGTM 👍
Nit: In the commit message, you don't need [b3dda0e]: b3dda0e. Just use the first few digits of the SHA and GitHub will recognize it automatically and turn it into a link.
For future reference:
I don't think there a straight forward way to test this (given that URL is a built-in) and given how simple and non-controversial change this is, I think it is fine not having a test (famous last word 😁).
|
^^ 🤞 |
|
@IgorMinar @gkalpak Hello! |
|
@H--o-l, can you please update the commit message to not contain
|
Since Angular v8, and commit b3dda0e, `parseUrl()` can be called without `relativeTo`, thus `new URL()` can be called with `relativeTo = undefined`. Safari does not like it and the service worker registration fails: ```js new URL('https://angular.io/') // OK new URL('https://angular.io/', undefined) // TypeError ``` Closes angular#31061
34d7dc5 to
36066a9
Compare
|
@gkalpak Oh ok, since you accepted the PR in the same time you made the remark, I believed it was not mandatory. |
|
Sorry for the confusion, @H--o-l. I approved it, but added the I marked the PR for merging. Thx, again, for working on this ❤️ |
Since Angular v8, and commit b3dda0e, `parseUrl()` can be called without `relativeTo`, thus `new URL()` can be called with `relativeTo = undefined`. Safari does not like it and the service worker registration fails: ```js new URL('https://angular.io/') // OK new URL('https://angular.io/', undefined) // TypeError ``` Closes #31061 PR Close #31140
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Service worker failed to register on Safari.
What is the new behavior?
Registered service worker.
Does this PR introduce a breaking change?
Other information
It's a regression of Angular v8, it was ok in v7.
Closes #31061