Skip to content

docs: update example references from "my-app" to "app-root" - #30789

Closed
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:docs-examples-app-root
Closed

docs: update example references from "my-app" to "app-root"#30789
brandonroberts wants to merge 1 commit into
angular:masterfrom
brandonroberts:docs-examples-app-root

Conversation

@brandonroberts

@brandonroberts brandonroberts commented May 31, 2019

Copy link
Copy Markdown
Contributor

"app" is the default prefix for CLI projects when generating components.
This updates our examples to conform that that default

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #19778

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@brandonroberts
docs: update example references from "my-app" to "app-root"
aecd887 
"app" is the default prefix for CLI projects when generating components.
This updates our examples to conform that that default

Closes angular#19778
@brandonroberts
brandonroberts requested review from a team May 31, 2019 20:13
@mary-poppins

mary-poppins commented May 31, 2019

Copy link
Copy Markdown

You can preview aecd887 at https://pr30789-aecd887.ngbuilds.io/.

@gkalpak gkalpak added comp: docs action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release refactoring Issue that involves refactoring or code-cleanup labels Jun 1, 2019
@ngbot ngbot Bot modified the milestone: needsTriage Jun 1, 2019
@gkalpak

gkalpak commented Jun 1, 2019

Copy link
Copy Markdown
Member

merge-assistance: Global approval for this docs-only change.

@ngbot ngbot Bot modified the milestones: needsTriage, Backlog Jun 2, 2019
@mhevery mhevery closed this in 8bedf50 Jun 3, 2019
mhevery pushed a commit that referenced this pull request Jun 3, 2019
@brandonroberts @mhevery
docs: update example references from "my-app" to "app-root" (#30789)
393529d 
"app" is the default prefix for CLI projects when generating components.
This updates our examples to conform that that default

Closes #19778

PR Close #30789
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@gkalpak gkalpak gkalpak approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes effort1: hours merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note refactoring Issue that involves refactoring or code-cleanup risk: low target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@brandonroberts @mary-poppins @gkalpak @googlebot