Skip to content

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat… - #30714

Closed
cexbrayat wants to merge 1 commit into
angular:masterfrom
cexbrayat:fix/29905-test-bed-get
Closed

fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…#30714
cexbrayat wants to merge 1 commit into
angular:masterfrom
cexbrayat:fix/29905-test-bed-get

Conversation

@cexbrayat

@cexbrayat cexbrayat commented May 29, 2019

Copy link
Copy Markdown
Member

…ic.get overload

Followup to #30514 which did the same for TestBed, but TestBedStatic was necessary too.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #29905

@cexbrayat
fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
46abc4f 
…ic.get overload

Followup to angular#30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.
@cexbrayat
cexbrayat requested review from a team May 29, 2019 07:13
@matsko matsko added the area: core Issues related to the framework runtime label May 30, 2019
@ngbot ngbot Bot added this to the needsTriage milestone May 30, 2019
kara
kara approved these changes Jun 13, 2019
View reviewed changes

@kara kara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Jun 13, 2019
@kara

kara commented Jun 13, 2019

Copy link
Copy Markdown
Contributor

Merge assistance: global approval

AndrewKushnir pushed a commit that referenced this pull request Jun 14, 2019
@cexbrayat @AndrewKushnir
fix(core): temporarily remove @deprecated jsdoc tag for a TextBedStat…
0a7aebb 
…ic.get overload (#30714)

Followup to #30514 which did the same for `TestBed`, but `TestBedStatic` was necessary too.

PR Close #30714
@cexbrayat
cexbrayat deleted the fix/29905-test-bed-get branch June 18, 2019 15:33
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Sep 15, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@petebacondarwin petebacondarwin petebacondarwin approved these changes
@kara kara kara approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime cla: yes merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@cexbrayat @kara @petebacondarwin @matsko @googlebot